[rocWMMA] CMake changes for integration into TheRock#2322
Merged
Conversation
1 task
Contributor
Author
bsyrowik
force-pushed
the
users/bsyrowik/rocwmma_therock
branch
2 times, most recently
from
1d099aa to
24aa49e
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the rocWMMA test infrastructure by upgrading GoogleTest to version 1.16.0, modernizing the CMake configuration, and adding support for smoke and regression test suites.
Key changes:
- Upgraded GoogleTest from version 1.12.1 to 1.16.0 with improved FetchContent integration
- Added separate test file generation for smoke and regression test suites
- Updated CMake to prefer Ninja generator and export package targets
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| projects/rocwmma/test/CMakeLists.txt | Updated GoogleTest to 1.16.0, modernized FetchContent usage, added smoke/regression test files, and fixed rpath escaping |
| projects/rocwmma/samples/CMakeLists.txt | Fixed comment to correctly describe "binaries" instead of "gtests" |
| projects/rocwmma/CMakeLists.txt | Added Ninja generator preference warning and CMake package export configuration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bsyrowik
force-pushed
the
users/bsyrowik/rocwmma_therock
branch
3 times, most recently
from
53c4884 to
9073684
Compare
bsyrowik
force-pushed
the
users/bsyrowik/rocwmma_therock
branch
from
9073684 to
f74f6fb
Compare
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
bsyrowik
force-pushed
the
users/bsyrowik/rocwmma_therock
branch
from
f74f6fb to
55ca59e
Compare
Contributor
Author
|
/AzurePipelines run rocm-ci-caller |
|
Azure Pipelines successfully started running 1 pipeline(s). |
assistant-librarian Bot
pushed a commit
to ROCm/rocWMMA
that referenced
this pull request
Nov 7, 2025
[rocWMMA] CMake changes for integration into TheRock ## Motivation These changes are required to integrate rocWMMA into TheRock. This PR subsumes the patches from my PR for TheRock here: ROCm/TheRock#1938 ## Technical Details Mostly changes to testing and CMake configuration. Notably: - Update googletest dependency. - Create new regression and smoke test ctest files. - Suggest using Ninja. - Export the project. ## Test Plan TheRock CI: https://github.com/ROCm/TheRock/actions/runs/18804601794 An equivalent PR from ROCm/rocWMMA passed all checks as well: https://github.com/ROCm/rocWMMA/pull/601/checks ## Test Result Tests passed ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.
qiangpan2
pushed a commit
to qiangpan2/rocm-libraries
that referenced
this pull request
May 29, 2026
[ROCm/composable_kernel commit: 3af66e9]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
These changes are required to integrate rocWMMA into TheRock. This PR subsumes the patches from my PR for TheRock here: ROCm/TheRock#1938
Technical Details
Mostly changes to testing and CMake configuration.
Notably:
Test Plan
TheRock CI:
https://github.com/ROCm/TheRock/actions/runs/18804601794
An equivalent PR from ROCm/rocWMMA passed all checks as well:
https://github.com/ROCm/rocWMMA/pull/601/checks
Test Result
Tests passed
Submission Checklist