Revert "[MIOpen] Implement kernel tuning heuristic model for 3D conv …#1740
Merged
Conversation
SreecharanGundaboluAMD
approved these changes
Sep 23, 2025
1 task
assistant-librarian Bot
pushed a commit
to ROCm/MIOpen
that referenced
this pull request
Sep 23, 2025
=?UTF-8?q?Revert=20"[MIOpen]=20Implement=20kernel=20tunin?= =?UTF-8?q?g=20heuristic=20model=20for=203D=20conv=20=E2=80=A6=20(#1740)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit …ops (two tower model) (#1154)" This reverts commit 422e87293e9d52dd399a1801313f9017be29291d. ## Motivation That commit broke MI300 unit tests. ## Test Plan Reverted this change and verified that the failing build now passes ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.
amd-bartgips
added a commit
that referenced
this pull request
Oct 22, 2025
## Motivation Bugfix to avoid reverting as suggested in #1740 . MI300 test pipeline shows test failures in: projects/miopen/test/gtest/group_conv3d_bwd.cpp projects/miopen/test/gtest/group_conv3d_fwd.cpp projects/miopen/test/gtest/group_conv3d_wrw.cpp ## Technical Details The tests failed because of errors such as: `MIOpen(HIP): Error [InitInvokerFactoryNHWC] PerformanceConfig kernel 'DeviceGroupedConvFwdMultipleABD_Xdl_CShuffle<256, 64, 64, 32, Default, 16, 16, 2, 2, 1, 2, 1, 1, 1, 1>' does not exist.` This was caused by the run_ai_heuristics functions not properly initialising the valid_kernels. It did not take into account `problem.GetAlphaBetaCase()`, so these errors could occur in the BILINEAR and SCALE cases. ## Test Plan <!-- Explain any relevant testing done to verify this PR. --> ## Test Result <!-- Briefly summarize test outcomes. --> ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ops (two tower model) (#1154)"
This reverts commit 422e872.
Motivation
That commit broke MI300 unit tests.
Test Plan
Reverted this change and verified that the failing build now passes
Submission Checklist