Repository navigation
Tune gfx950 BBS_TN,NN,TN and SGEMM Equality liblogics - #1589
Closed
minsukim-amd wants to merge 3 commits into
Closed
minsukim-amd wants to merge 3 commits into
minsukim-amd wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces updated Tensile logic configurations for optimizing GEMM operations on the gfx950 architecture, specifically targeting improved performance for BBS_TN,NN,TN and SGEMM equality operations with bias support.
- Updates matrix multiplication kernel configurations for different transpose patterns (BT and TT operations)
- Introduces new kernel configurations with various tile sizes and memory optimization parameters
- Adds two new YAML configuration files for handling different GEMM transpose combinations
Reviewed Changes
Copilot reviewed 2 out of 7 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| gfx950_Cijk_Alik_Bljk_S_B_Bias_HAS_SAV_UserArgs.yaml | New configuration for A^T * B (transpose A, normal B) GEMM operations with bias support |
| gfx950_Cijk_Alik_Bjlk_S_B_Bias_HAS_SAV_UserArgs.yaml | New configuration for A^T * B^T (both matrices transposed) GEMM operations with bias support |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
minsukim-amd
changed the title
aferoz21
approved these changes
Sep 16, 2025
Contributor
Author
|
Close as it's a duplicate of PR1614 |
qiangpan2
pushed a commit
to qiangpan2/rocm-libraries
that referenced
this pull request
May 29, 2026
* Enable grouped conv bwd wei bf16 NGCHW * fixes * fixes * Fixes * fixes * fixes * Fixes [ROCm/composable_kernel commit: 82fc538]
JonathanLichtnerAMD
added a commit
that referenced
this pull request
Oct 2, 2026
…12800) JIRA ID: ALMIOPEN-2820 ## Motivation Reverts #12496 (320f7a8), which added `gfx1250;gfx1250-strict` to the MIOpen dev image arch lists. With those archs, the CK stage of the Docker image build (`build_ck`, Dockerfile:375) fails: ``` ld.lld: error: local memory (131552) exceeds limit (65536) ``` CK's `CK_USE_GFX1250`-gated large-LDS wmma grouped-conv instances are also compiled for gfx1101/gfx1151 (64 KB LDS). This broke the MIOpen develop nightly (Jenkins `rocm-libraries-folder/MIOpen/develop` #1589 and #1590) at "Build Docker for CI"; the last good run was #1588. The break was masked for about a day because the CI image tag hash does not include the arch list, so #1584-#1588 reused a stale image until an unrelated CK `CMakeLists.txt` change (#12686) forced a rebuild. The CK-side fix is tracked in AICK-2468. gfx1250 can be re-added to the dev image once that lands. ## Technical Details In `projects/miopen/vars/utils.groovy`, remove `gfx1250;gfx1250-strict` from two arch lists: - the `ci` list in `getDockerImage()` - the `:therock` multiarch list in `buildTheRockDockerImage()` ## Risk Assessment **Risk Level: 🟢 Low** ### Impacted Components MIOpen Jenkins CI Docker image build (`projects/miopen/vars/utils.groovy`) only; no library code changes. ### Potential Side Effects gfx1250 is temporarily absent from the `rocm/miopen-dev` image. ### Mitigation Steps Re-add gfx1250 to the dev image once the CK fix (AICK-2468) lands. ## Test Plan Verify on the next develop nightly: the forced CI image rebuild completes `build_ck`, then Build Docker for CI, Full Tests, Publish Dev Image and Nightly Tests pass. ## Test Result Not yet run; verification is the next develop nightly (see Test Plan).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Bring uplift for BBS_NN,NT,TN and SGEMM_NN,NT,TN,TT
Submission Checklist