[rocThrust] use fetch_content to replace download_project#1578
Merged
umfranzw merged 2 commits intoNov 13, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1578 +/- ##
===========================================
+ Coverage 78.35% 83.46% +5.11%
===========================================
Files 24 502 +478
Lines 5340 43180 +37840
Branches 730 5459 +4729
===========================================
+ Hits 4184 36040 +31856
- Misses 943 2898 +1955
- Partials 213 4242 +4029
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
umfranzw
reviewed
Oct 1, 2025
umfranzw
approved these changes
Oct 1, 2025
umfranzw
requested changes
Oct 1, 2025
umfranzw
approved these changes
Oct 9, 2025
umfranzw
approved these changes
Nov 12, 2025
1 task
qiangpan2
pushed a commit
to qiangpan2/rocm-libraries
that referenced
this pull request
May 29, 2026
[ROCm/composable_kernel commit: 794f2d6]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
rocPRIM has been updated to be using FetchContent vs. DownloadProject due to some of it's shortcomings. To have less variants of the build definition flying around, homogenize them to ease maintenance.
Technical Details
Removed
DownloadProjectand replaced it withFetchContent`.Test Plan
The rocThrust build CI should set everything to default and let rocTrhust to find and download dependencies automatically, in order to do this, we can set
FORCE_DEPENDENCIES_DOWNLOADtoONTest Result
Submission Checklist