Skip to content

[rocThrust] use fetch_content to replace download_project#1578

Merged
umfranzw merged 2 commits into
ROCm:developfrom
StreamHPC:users/cenxuantian/replace-download_project-with-fetchcontent
Nov 13, 2025
Merged

[rocThrust] use fetch_content to replace download_project#1578
umfranzw merged 2 commits into
ROCm:developfrom
StreamHPC:users/cenxuantian/replace-download_project-with-fetchcontent

Conversation

@cenxuantian
Copy link
Copy Markdown
Contributor

Motivation

rocPRIM has been updated to be using FetchContent vs. DownloadProject due to some of it's shortcomings. To have less variants of the build definition flying around, homogenize them to ease maintenance.

Technical Details

Removed DownloadProjectand replaced it with FetchContent`.

Test Plan

The rocThrust build CI should set everything to default and let rocTrhust to find and download dependencies automatically, in order to do this, we can set FORCE_DEPENDENCIES_DOWNLOAD to ON

Test Result

Submission Checklist

@cenxuantian cenxuantian requested a review from a team as a code owner September 15, 2025 14:30
@assistant-librarian assistant-librarian Bot added the external contribution Code contribution from users community.. label Sep 15, 2025
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1578      +/-   ##
===========================================
+ Coverage    78.35%   83.46%   +5.11%     
===========================================
  Files           24      502     +478     
  Lines         5340    43180   +37840     
  Branches       730     5459    +4729     
===========================================
+ Hits          4184    36040   +31856     
- Misses         943     2898    +1955     
- Partials       213     4242    +4029     
Flag Coverage Δ
hipSPARSELt ?
rocThrust 83.41% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 526 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread projects/rocthrust/cmake/Dependencies.cmake Outdated
Copy link
Copy Markdown
Contributor

@umfranzw umfranzw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this. I just had one minor comment.

Comment thread projects/rocthrust/cmake/Dependencies.cmake Outdated
@umfranzw umfranzw self-requested a review November 12, 2025 15:56
@umfranzw umfranzw merged commit be7dcd2 into ROCm:develop Nov 13, 2025
24 of 25 checks passed
qiangpan2 pushed a commit to qiangpan2/rocm-libraries that referenced this pull request May 29, 2026
[ROCm/composable_kernel commit: 794f2d6]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external contribution Code contribution from users community.. project: rocthrust

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants