Repository navigation
Conversation
Pass KUBE_CPU_REQUEST into the focused hipBLASLt/hipSPARSELt HOST_ASAN containers and set OpenMP and OpenBLAS thread budgets from its integer CPU allocation, following TheRock component CI. Preserve inherited settings when the allocation is unavailable or invalid. Let host-ASAN hipBLASLt retain the configured OpenMP budget; keep the existing full-device-ASAN overrides. Restore the 128x128 NN/NT/TN/TT strided-batched hipSPARSELt smoke cases under ASAN. Add launch-boundary regression checks to the workflow setup job and document the runtime policy. The checks reproduce both issues before the change and pass afterward; eight allocation parsing cases and pre-commit checks pass. GPU CI timing measurements are pending. JIRA ID : AIHPBLAS-5081
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA ID : AIHPBLAS-5081
Motivation
The focused hipBLASLt/hipSPARSELt HOST_ASAN workflow omits TheRock's allocation-derived CPU budget. hipSPARSELt therefore uses runtime defaults, while the hipBLASLt wrapper forces one OpenMP thread. The sparse quick selection also excludes the slow 128x128 strided-batched smoke cases.
Technical Details
Forward
KUBE_CPU_REQUESTinto the focused test containers and set bothOMP_NUM_THREADSandOPENBLAS_NUM_THREADSto its integer CPU allocation, with a minimum of one. Missing or invalid allocation metadata preserves inherited settings. Apply the setup to both libraries on gfx942 and gfx950.Let host-ASAN hipBLASLt inherit that budget, retaining the existing full-device-ASAN overrides. Remove the NN/NT/TN/TT 128x128 ASAN exclusions from hipSPARSELt's quick filter while retaining the known-bug exclusion. Add wrapper regression checks to the existing CPU setup job and document the runtime policy. This commit contains no C++ thread cap or rocRoller optimization.
This follows the ordinary TheRock component-job budget setup and updates the focused workflow introduced by #14240. The HOST_ASAN summary remains informational rather than a required merge check.
Test Plan
Test Result
The wrapper regression checks fail on the parent revision for the host-ASAN budget override and sparse exclusions, and all three checks pass with this change. Eight allocation-parsing cases pass. Pre-commit passes. GPU CI timing and the local sweep are pending; this draft makes no speedup claim.
Submission Checklist
Risk level
Medium: test-client CPU concurrency changes and previously excluded sparse cases run again under ASAN. Existing sanitizer settings, test correctness checks and timeouts remain in place. hipSPARSELt has no component TESTING.md; its README documents the test executable, and the shared host-ASAN policy is documented in hipBLASLt's TESTING.md.