Skip to content

test(miopen)[ALMIOPEN-3097]: destroy find-2.0 solutions in na_*find2 tests and re-enable them under ASAN #15016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aalabsi-amd merged 2 commits into from
Nov 9, 2026
Merged

test(miopen)[ALMIOPEN-3097]: destroy find-2.0 solutions in na_*find2 tests and re-enable them under ASAN #15016

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ef22ba
test(miopen)[ALMIOPEN-3097]: destroy find-2.0 solutions in na_*find2 …
aalabsi-amd Nov 3, 2026
0dc7dfc
test(miopen)[ALMIOPEN-3097]: own find-2.0 solutions with RAII in na_*…
aalabsi-amd Nov 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions projects/miopen/test/gtest/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,12 +65,6 @@ if(THEROCK_SANITIZER STREQUAL "ASAN")
# temporarily disable: LeakSanitizer reports a memory leak at exit
# (assertions pass but the process leaks).
list(APPEND SKIP_TESTS find_2_conv.cpp)
# temporarily disable (ALMIOPEN-3097): LeakSanitizer reports leaks at exit because these tests never call
# miopenDestroySolution on the solutions returned by miopenFindSolutions (assertions pass).
list(APPEND SKIP_TESTS
na_inference_find2.cpp
na_train_find2.cpp
)
# temporarily disable: these fail under ASan even when run individually
# on gfx942.
list(APPEND SKIP_TESTS
Expand Down
1 change: 1 addition & 0 deletions projects/miopen/test/gtest/na_inference_find2.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,6 +177,7 @@ struct verify_inference_batchnorm_activ
const auto run_ret = miopenRunSolution(
&handle, solution, run_tensors.size(), run_tensors.data(), nullptr, 0);
EXPECT_EQ(run_ret, miopenStatusSuccess);
EXPECT_EQ(miopenDestroySolution(solution), miopenStatusSuccess);
}

baout.data = handle.Read<T>(out_dev, baout.data.size());
Expand Down
4 changes: 4 additions & 0 deletions projects/miopen/test/gtest/na_train_find2.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,7 @@ struct verify_fwd_batchnorm_spatial_activ
const auto run_ret = miopenRunSolution(
&handle, solution, run_tensors.size(), run_tensors.data(), nullptr, 0);
EXPECT_EQ(run_ret, miopenStatusSuccess);
EXPECT_EQ(miopenDestroySolution(solution), miopenStatusSuccess);
}

baout.data = handle.Read<T>(out_dev, baout.data.size());
Expand Down Expand Up @@ -380,6 +381,7 @@ struct verify_bwd_batchnorm_spatial_activ
const auto run_ret = miopenRunSolution(
&handle, solution, run_tensors.size(), run_tensors.data(), nullptr, 0);
EXPECT_EQ(run_ret, miopenStatusSuccess);
EXPECT_EQ(miopenDestroySolution(solution), miopenStatusSuccess);
}

dx.data = handle.Read<T>(dxout_dev, dx.data.size());
Expand Down Expand Up @@ -547,6 +549,7 @@ struct verify_fwd_batchnorm_peract_activ
const auto run_ret = miopenRunSolution(
&handle, solution, run_tensors.size(), run_tensors.data(), nullptr, 0);
EXPECT_EQ(run_ret, miopenStatusSuccess);
EXPECT_EQ(miopenDestroySolution(solution), miopenStatusSuccess);
}

baout.data = handle.Read<T>(out_dev, baout.data.size());
Expand Down Expand Up @@ -722,6 +725,7 @@ struct verify_bwd_batchnorm_peract_activ
const auto run_ret = miopenRunSolution(
&handle, solution, run_tensors.size(), run_tensors.data(), nullptr, 0);
EXPECT_EQ(run_ret, miopenStatusSuccess);
EXPECT_EQ(miopenDestroySolution(solution), miopenStatusSuccess);
}

dx.data = handle.Read<T>(dxout_dev, dx.data.size());
Expand Down
Loading