Repository navigation
fix(origami): charge the PostGSU reduction kernel launch - #14783
Merged
Merged
Conversation
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #14783 +/- ##
========================================
Coverage 77.34% 77.34%
========================================
Files 2894 2894
Lines 487274 487204 -70
Branches 73752 73713 -39
========================================
- Hits 376857 376808 -49
- Misses 85525 85539 +14
+ Partials 24892 24857 -35
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
The separate PostGSU reduction kernel's launch cost was dropped from compute_parallel_reduction_latency. Restore it as POSTGSU_KERNEL_LAUNCH_OVERHEAD (1.6 us), calibrated on gfx950 back-to-back hipblaslt-bench timing. Co-authored-by: Cursor <cursoragent@cursor.com>
…arge Charging the PostGSU reduction kernel launch moves 22 rankings: 14 on gfx950, 4 on gfx90a, 2 on gfx1101 and 2 on gfx1200. Co-authored-by: Cursor <cursoragent@cursor.com>
aliry95amd
force-pushed
the
users/aliry95amd/Origami_VectorWidth
branch
from
October 30, 2026 23:25
efffd3b to
0c2ee39
Compare
yenong-amd
approved these changes
Oct 31, 2026
Contributor
TheRock Submodule Bump ActivityNewest first
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA ID : AIHPBLAS-1972
Motivation
The separate PostGSU reduction kernel's launch cost was dropped from compute_parallel_reduction_latency. Restore it as POSTGSU_KERNEL_LAUNCH_OVERHEAD (1.6 us), calibrated on gfx950 back-to-back hipblaslt-bench timing.
Technical Details
Test Plan
Passed
Test Result
Passed
Submission Checklist