Skip to content

fix(origami): charge the PostGSU reduction kernel launch - #14783

Merged
yenong-amd merged 3 commits into
developfrom
users/aliry95amd/Origami_VectorWidth
Oct 31, 2026
Merged

yenong-amd merged 3 commits into
developfrom
users/aliry95amd/Origami_VectorWidth

Conversation

@aliry95amd

Copy link
Copy Markdown
Contributor

JIRA ID : AIHPBLAS-1972

Motivation

The separate PostGSU reduction kernel's launch cost was dropped from compute_parallel_reduction_latency. Restore it as POSTGSU_KERNEL_LAUNCH_OVERHEAD (1.6 us), calibrated on gfx950 back-to-back hipblaslt-bench timing.

Technical Details

Test Plan

Passed

Test Result

Passed

Submission Checklist

@therock-pr-bot

therock-pr-bot Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

✅ All Checks Passed — Ready for Review

Check Status Details
📝 PR Description ✅ Pass —
⛔ Forbidden Files ✅ Pass —
🧪 Unit Test ✅ Pass —
🔎 pre-commit ✅ Pass —
🚫 Draft PR 🔜 To Be Enabled —
🚩 Feature Flag 🔜 To Be Enabled —
📊 Code Coverage 🔜 To Be Enabled —
🤖 therock-pr-bot ✅ Pass —

🎉 All checks passed! This PR is ready for review.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@therock-pr-bot

Copy link
Copy Markdown

🎉 All checks passed! This PR is ready for review.

@codecov

codecov Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #14783   +/-   ##
========================================
  Coverage    77.34%   77.34%           
========================================
  Files         2894     2894           
  Lines       487274   487204   -70     
  Branches     73752    73713   -39     
========================================
- Hits        376857   376808   -49     
- Misses       85525    85539   +14     
+ Partials     24892    24857   -35     
Flag Coverage Δ *Carryforward flag
TensileLite-CPP 50.96% <ø> (+<0.01%) ⬆️
TensileLite-Unit 84.03% <ø> (ø)
hipBLAS 90.62% <ø> (ø) Carriedforward from 0c2ee39
hipBLASLt 68.40% <ø> (ø)
hipCUB 82.68% <ø> (ø) Carriedforward from 0c2ee39
hipDNN 86.92% <ø> (-0.04%) ⬇️ Carriedforward from 0c2ee39
hipFFT 43.18% <ø> (+0.52%) ⬆️ Carriedforward from 0c2ee39
hipRAND 76.12% <ø> (ø) Carriedforward from 0c2ee39
hipSOLVER 69.67% <ø> (ø) Carriedforward from 0c2ee39
hipSPARSE 87.03% <ø> (ø) Carriedforward from 0c2ee39
rocBLAS 69.11% <ø> (-0.08%) ⬇️ Carriedforward from 0c2ee39
rocFFT 47.36% <ø> (+0.13%) ⬆️ Carriedforward from 0c2ee39
rocRAND 57.32% <ø> (ø) Carriedforward from 0c2ee39
rocSOLVER 76.74% <ø> (ø) Carriedforward from 0c2ee39
rocSPARSE 83.54% <ø> (ø) Carriedforward from 0c2ee39
rocThrust 93.15% <ø> (ø) Carriedforward from 0c2ee39

*This pull request uses carry forward flags. Click here to find out more.
see 63 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

aliry95amd and others added 2 commits October 30, 2026 23:06
The separate PostGSU reduction kernel's launch cost was dropped from
compute_parallel_reduction_latency. Restore it as POSTGSU_KERNEL_LAUNCH_OVERHEAD
(1.6 us), calibrated on gfx950 back-to-back hipblaslt-bench timing.

Co-authored-by: Cursor <cursoragent@cursor.com>
…arge

Charging the PostGSU reduction kernel launch moves 22 rankings: 14 on gfx950, 4 on gfx90a, 2 on gfx1101 and 2 on gfx1200.

Co-authored-by: Cursor <cursoragent@cursor.com>
@aliry95amd
aliry95amd force-pushed the users/aliry95amd/Origami_VectorWidth branch from efffd3b to 0c2ee39 Compare October 30, 2026 23:25
@yenong-amd
yenong-amd merged commit d1de210 into develop Oct 31, 2026
165 of 168 checks passed
@yenong-amd
yenong-amd deleted the users/aliry95amd/Origami_VectorWidth branch October 31, 2026 23:03
@assistant-librarian

Copy link
Copy Markdown
Contributor

TheRock Submodule Bump Activity

Newest first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants