Repository navigation
fix(hipdnn): let hipdnn-deep-review continue a published review - #14766
Merged
BrianHarrisonAMD merged 2 commits intoOct 30, 2026
Merged
Conversation
github-actions
Bot
added
documentation
ci:docs-only
BrianHarrisonAMD
marked this pull request as ready for review
October 30, 2026 17:43
BrianHarrisonAMD
enabled auto-merge (squash)
October 30, 2026 17:46
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
GarbyGilbertAMD
approved these changes
Oct 30, 2026
GarbyGilbertAMD
left a comment
GarbyGilbertAMD
left a comment
Contributor
There was a problem hiding this comment.
Gave it a mock run, worked nicely. LGTM!
BrianHarrisonAMD
deleted the
users/bharriso/deep-review-resume-packaged
branch
October 30, 2026 20:01
Contributor
TheRock Submodule Bump ActivityNewest first
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hipdnn-deep-reviewcan now continue a review whose earlier rounds exist only as a published record someone else ran. Before this, the next round silently computed an empty set of affected files and could not close while answered questions were still listed as open.JIRA ID : ALMIOPEN-2945
Risk Assessment
Risk 1. Skill documentation only; no script, product or build change.
Testing Summary
develop.Testing Checklist
Closure: CLOSED)python3 -m pytest projects/hipdnn/tools/ai/tests- Status: Passed (333 passed, 7 skipped; 1 failure also present ondevelop, inhipdnn-ingestor-engine)python3 projects/hipdnn/tools/ai/validate-skills.py- Status: Passed for this skill (samehipdnn-ingestor-enginelink error asdevelop)Technical Changes
prior:<dir>for a published record of earlier rounds.$EVIDENCEfrom that record and settle answered open questions first.affected.txttakes the previous round's files from git, so a round folder withoutfiles.txtworks.