Skip to content

[TheRock CI] Adding dynamic selecting of TheRock tests#147

Merged
geomin12 merged 4 commits into
developfrom
users/geomin12/dynamic-selecting-2
Jun 5, 2025
Merged

[TheRock CI] Adding dynamic selecting of TheRock tests#147
geomin12 merged 4 commits into
developfrom
users/geomin12/dynamic-selecting-2

Conversation

@geomin12
Copy link
Copy Markdown
Collaborator

@geomin12 geomin12 commented Jun 4, 2025 •
edited
Loading

Currently, the rocprim test was hard-coded. Now, we are able to run tests based on what change has occurred.

progress on ROCm/TheRock#665

@geomin12 geomin12 requested a review from ScottTodd June 4, 2025 21:41
geomin12
geomin12 commented Jun 4, 2025
View reviewed changes
Comment thread .github/workflows/therock-ci.yml Outdated
@geomin12
Copy link
Copy Markdown
Collaborator Author

geomin12 commented Jun 4, 2025

Working here: https://github.com/ROCm/rocm-libraries/actions/runs/15453395156/job/43503277255?pr=147

marbre
marbre previously approved these changes Jun 5, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@marbre marbre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some naming suggestions.

Comment thread .github/scripts/therock_matrix.py Outdated
Comment thread .github/workflows/therock-ci-linux.yml Outdated
Comment thread .github/workflows/therock-ci-linux.yml Outdated
@geomin12 geomin12 requested a review from marbre June 5, 2025 18:51
@geomin12 geomin12 merged commit 13d5f64 into develop Jun 5, 2025
8 of 9 checks passed
@geomin12 geomin12 deleted the users/geomin12/dynamic-selecting-2 branch June 5, 2025 19:18
@geomin12 geomin12 mentioned this pull request Jun 5, 2025
Closed
ScottTodd
ScottTodd reviewed Jun 24, 2025
View reviewed changes
Comment thread .github/workflows/therock-ci-linux.yml
@@ -0,0 +1,34 @@
name: TheRock CI
Copy link
Copy Markdown
Member

@ScottTodd ScottTodd Jun 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This name is shared with therock-ci.yml so https://github.com/ROCm/rocm-libraries/actions shows two actions with the same name:
image

Copy link
Copy Markdown
Collaborator Author

@geomin12 geomin12 Jun 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack! good catch, will update in one of the PRs

ammallya pushed a commit that referenced this pull request Sep 24, 2025
@SamuelReeder @mousdahl-amd
@adickin-amd @bghimireamd @jerehartAMD @BrianHarrisonAMD
Rename integration branch (#151)
839cf6c 
* Defaulting clang-tidy checks to off during rename process

* New rules

* Descriptors renamed (#135)

* New rules

* Descriptors renamed

* Formatting fixes

* rename backend/src/plugin folder (#136)

* rename backend/src/plugin folder

* fix comments

* missed 2 changes

* Missed renaming shared library as part of plugins (#139)

* Handle Renamed (#134)

* rename handles

* ignore hipdnnHandle in clang tidy

* review comments

* rename miopen legacy plugin engines. (#141)

* Backend Rename Leftovers (#138)

* Performed the rest of the backend renames

* Format

* PR comments

* Renaming in hipdnn_frontend/attributes (#140)

Update naming for our new tidy rules

* renames for miopen_legacy_plugin/root (#142)

* Renaming miopen legacy plugin base dir

* fix missed variable and function

* Rename sdk plugin (#145)

* Rename Engine_config_interface

* fix tests

* Convert wrappers and test utils

* Remaining plugin sdk renames

* formatting

* Apply formatting

* Fix snake_case for last_erorr

* Renaming in miopen legacy tests (#143)

* first batch of legacy tests

* tests set 2 for miopen legacy plugin

* missed integration tests, fix small issues

* fix

* another fix

* rename

* Rename sdk plugin tests (#148)

* Rename sdk/include/hipdnn_sdk/test_utilties symbols and usages (#146)

* Rename sdk/include/hipdnn_sdk/test_utilties symbols and usages

* Format

* Fix test_tensor names

* merge conflicts fix

* format changes

* format

---------

Co-authored-by: Brian Harrison <brian.harrison@amd.com>

* Update sdk logging names (#147)

Co-authored-by: Brian Harrison <brian.harrison@amd.com>

* Rename sdk test_utilities tests (#150)

* Renaming complete in sdk utilities, tests, and samples. (#149)

* Apply formatting

* Rename frontend's backend wrappers and helpers (#152)

* Renamed frontend's backend wrappers and helpers

* Format

* Rename backend integration tests (#153)

* Rename backend integration tests

* formatting

* Fix missing rename variable

* Renaming frontend/node and base dir (#157)

* miopen plugin interface renames (#158)

* /backend/tests/ rename (#156)

* /backend/tests/ rename

* Uncomment

* Change global

* Rename test plugins (#160)

* Rename test plugins for the new naming scheme

* Formatting

* Fix accidental rename

* Camel case for InitialziePlugin

* Samples renamed (#159)

* Renamed samples

* Format

* Typo and wrong casing

---------

Co-authored-by: Samuel Reeder <samuel.reeder@amd.com>

* Frontend integration tests renamed (#161)

* Rename sdk tests utilities (#162)

* Rename sdk test utilities to match new scheme

* Swap to s_ instead of g_ for local static

* camelCase

* Replace global with test fixture (#163)

* Replace global with test fixture

* Change name

* Rename test internals (#164)

* Fix SDK tidy breaks

* Backend fixes

* More backend and updated clang-tidy for constexpr

* Fix tidy errors

* More tidy fixes for plugin, sdk, and backend

* NOLINT setters and more of frontend

* Fix backend tidy error

* More frontend fixes

* Lint free (by my reckoning)

* I did this by hand

* Add code style and naming doc (#165)

* style doc v1

* add table of contents

* fix first batch of comments

* review concerns, and new section 14

* add links to style doc from other places

* update both cline and copilot instructions to match (#166)

* Tidy fixes (#167)

* fix a few tidy issues

* change tidy to *

* Re-enable enum tidies

* default tidy back on

---------

Co-authored-by: Jeremy Hart <jeremy.hart@amd.com>

* fix formatting (#168)

---------

Co-authored-by: mousdahl-amd <mitch.ousdahl@amd.com>
Co-authored-by: Adam Dickin <adam.dickin@amd.com>
Co-authored-by: bibek <108366729+bghimireamd@users.noreply.github.com>
Co-authored-by: Jeremy Hart <jeremy.hart@amd.com>
Co-authored-by: BrianHarrisonAMD <169072757+BrianHarrisonAMD@users.noreply.github.com>
Co-authored-by: Brian Harrison <brian.harrison@amd.com>
ammallya pushed a commit that referenced this pull request Sep 24, 2025
@SamuelReeder
Rename integration branch (#151)
2894679 
* Defaulting clang-tidy checks to off during rename process

* New rules

* Descriptors renamed (#135)

* New rules

* Descriptors renamed

* Formatting fixes

* rename backend/src/plugin folder (#136)

* rename backend/src/plugin folder

* fix comments

* missed 2 changes

* Missed renaming shared library as part of plugins (#139)

* Handle Renamed (#134)

* rename handles

* ignore hipdnnHandle in clang tidy

* review comments

* rename miopen legacy plugin engines. (#141)

* Backend Rename Leftovers (#138)

* Performed the rest of the backend renames

* Format

* PR comments

* Renaming in hipdnn_frontend/attributes (#140)

Update naming for our new tidy rules

* renames for miopen_legacy_plugin/root (#142)

* Renaming miopen legacy plugin base dir

* fix missed variable and function

* Rename sdk plugin (#145)

* Rename Engine_config_interface

* fix tests

* Convert wrappers and test utils

* Remaining plugin sdk renames

* formatting

* Apply formatting

* Fix snake_case for last_erorr

* Renaming in miopen legacy tests (#143)

* first batch of legacy tests

* tests set 2 for miopen legacy plugin

* missed integration tests, fix small issues

* fix

* another fix

* rename

* Rename sdk plugin tests (#148)

* Rename sdk/include/hipdnn_sdk/test_utilties symbols and usages (#146)

* Rename sdk/include/hipdnn_sdk/test_utilties symbols and usages

* Format

* Fix test_tensor names

* merge conflicts fix

* format changes

* format

---------

Co-authored-by: Brian Harrison <brian.harrison@amd.com>

* Update sdk logging names (#147)

Co-authored-by: Brian Harrison <brian.harrison@amd.com>

* Rename sdk test_utilities tests (#150)

* Renaming complete in sdk utilities, tests, and samples. (#149)

* Apply formatting

* Rename frontend's backend wrappers and helpers (#152)

* Renamed frontend's backend wrappers and helpers

* Format

* Rename backend integration tests (#153)

* Rename backend integration tests

* formatting

* Fix missing rename variable

* Renaming frontend/node and base dir (#157)

* miopen plugin interface renames (#158)

* /backend/tests/ rename (#156)

* /backend/tests/ rename

* Uncomment

* Change global

* Rename test plugins (#160)

* Rename test plugins for the new naming scheme

* Formatting

* Fix accidental rename

* Camel case for InitialziePlugin

* Samples renamed (#159)

* Renamed samples

* Format

* Typo and wrong casing

---------

Co-authored-by: Samuel Reeder <samuel.reeder@amd.com>

* Frontend integration tests renamed (#161)

* Rename sdk tests utilities (#162)

* Rename sdk test utilities to match new scheme

* Swap to s_ instead of g_ for local static

* camelCase

* Replace global with test fixture (#163)

* Replace global with test fixture

* Change name

* Rename test internals (#164)

* Fix SDK tidy breaks

* Backend fixes

* More backend and updated clang-tidy for constexpr

* Fix tidy errors

* More tidy fixes for plugin, sdk, and backend

* NOLINT setters and more of frontend

* Fix backend tidy error

* More frontend fixes

* Lint free (by my reckoning)

* I did this by hand

* Add code style and naming doc (#165)

* style doc v1

* add table of contents

* fix first batch of comments

* review concerns, and new section 14

* add links to style doc from other places

* update both cline and copilot instructions to match (#166)

* Tidy fixes (#167)

* fix a few tidy issues

* change tidy to *

* Re-enable enum tidies

* default tidy back on

---------

Co-authored-by: Jeremy Hart <jeremy.hart@amd.com>

* fix formatting (#168)

---------

Co-authored-by: mousdahl-amd <mitch.ousdahl@amd.com>
Co-authored-by: Adam Dickin <adam.dickin@amd.com>
Co-authored-by: bibek <108366729+bghimireamd@users.noreply.github.com>
Co-authored-by: Jeremy Hart <jeremy.hart@amd.com>
Co-authored-by: BrianHarrisonAMD <169072757+BrianHarrisonAMD@users.noreply.github.com>
Co-authored-by: Brian Harrison <brian.harrison@amd.com>

[ROCm/hipDNN commit: 839cf6c]
evetsso pushed a commit to evetsso/rocm-libraries that referenced this pull request Dec 31, 2025
@rahulc-gh
Merge pull request ROCm#147 from AMD-ROCm-Internal/rahchoud_amdeng-pa…
3c76add 
…tch-7

[rocblas] adding gfx1250 target and related changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ScottTodd ScottTodd ScottTodd left review comments

@marbre marbre marbre approved these changes

@jayhawk-commits jayhawk-commits Awaiting requested review from jayhawk-commits

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@geomin12 @ScottTodd @marbre