[rkayaith]

JIRA ID : ROCM-33540

Motivation

rocRoller's in-process assembler acquires the linked executable from the code-object manager (COMGR) but never releases that reference. Each assembly leaks executable data, causing host AddressSanitizer runs to fail at exit (ROCM-33540).

Found while expanding ASAN testing in #14240.

Technical Details

Release the reference acquired by amd_comgr_action_data_get_data after copying the executable bytes. Destroying the dataset releases its own reference; it does not release this separately acquired reference.

Test Plan

With a host AddressSanitizer (HOST_ASAN) TheRock build, run the existing CPU-only test without leak suppressions:

env -u LD_LIBRARY_PATH -u LD_PRELOAD -u ROCROLLER_ASSEMBLER -u ROCROLLER_SAVE_ASSEMBLY \
  ASAN_OPTIONS=quarantine_size_mb=600:detect_leaks=1 LSAN_OPTIONS= \
  HIP_VISIBLE_DEVICES=-1 ROCR_VISIBLE_DEVICES= HSA_XNACK=0 \
  rocroller-tests --gtest_filter=AssemblerTest.Basic

Test Result

Leaked bytes went from 4,204 to 0.

The mci/rocm-libraries/code-analysis(rocroller) failure is pre-existing: the job fails before analysis at docker build -f null, the same way it does on develop and other PRs.

ASAN error output (before fix)

=================================================================
==1667238==ERROR: LeakSanitizer: detected memory leaks

Direct leak of 1240 byte(s) in 1 object(s) allocated from:
    #0 0x70e0e936daed in operator new(unsigned long, std::nothrow_t const&) /__w/rocm-libraries/rocm-libraries/TheRock/compiler/amd-llvm/compiler-rt/lib/asan/asan_new_delete.cpp:114:3
    #1 0x70e0cb7f51a5 in amd_comgr_create_data (/home/rkayaith/repos/iree-workspace/workspaces/hipblaslt-hipsparselt-host-asan/tmp/comgr-existing-test/current-pin-dist/bin/../lib/libamd_comgr.so.3+0x5f51a5) (BuildId: 14c1bc839727066f9233f0481c919d82cabe711d)
    #2 0x7ffe694a9f17  (<unknown module>)

Indirect leak of 2959 byte(s) in 1 object(s) allocated from:
    #0 0x70e0e935d174 in malloc /__w/rocm-libraries/rocm-libraries/TheRock/compiler/amd-llvm/compiler-rt/lib/asan/asan_malloc_linux.cpp:127:3
    #1 0x70e0cbb4d96d  (/home/rkayaith/repos/iree-workspace/workspaces/hipblaslt-hipsparselt-host-asan/tmp/comgr-existing-test/current-pin-dist/bin/../lib/libamd_comgr.so.3+0x94d96d) (BuildId: 14c1bc839727066f9233f0481c919d82cabe711d)
    #2 0x726170737069682c  (<unknown module>)

Indirect leak of 5 byte(s) in 1 object(s) allocated from:
    #0 0x70e0e935d174 in malloc /__w/rocm-libraries/rocm-libraries/TheRock/compiler/amd-llvm/compiler-rt/lib/asan/asan_malloc_linux.cpp:127:3
    #1 0x70e0cb7d1b06  (/home/rkayaith/repos/iree-workspace/workspaces/hipblaslt-hipsparselt-host-asan/tmp/comgr-existing-test/current-pin-dist/bin/../lib/libamd_comgr.so.3+0x5d1b06) (BuildId: 14c1bc839727066f9233f0481c919d82cabe711d)

SUMMARY: AddressSanitizer: 4204 byte(s) leaked in 3 allocation(s).

Submission Checklist

• Look over the contributing guidelines at https://github.com/ROCm/TheRock/blob/main/GOVERNANCE.md#pull-requests.

Risk level

Low (2/5): releases one acquired reference after the executable bytes have been copied.

[math-ci-jobs]

Generated Documentation

• Link to view Generated Docs.

[Copilot]

🟢 Approval recommended

No active review issues are recorded for the change adding cleanup of the COMGR executable-data reference after its bytes are copied.

No open issues 🎉

What changed in this PR

Fixes a host-memory leak in rocRoller’s in-process assembler, identified while expanding AddressSanitizer coverage.

Changes:

• Releases the executable-data reference acquired from COMGR after its bytes have been copied.
• The PR reports that the existing CPU-only assembler test’s detected leaks dropped from 4,204 bytes to zero.

File	Description
shared/​rocroller/​lib/​source/​Assemblers/​InProcessAssembler.cpp	Adds the missing amd_comgr_release_data(execData) cleanup call.

_{Review effort: Balanced}

[math-ci-jobs]

Code Coverage Report for gfx950

Summary

Type	Total	Missed	Master Missed	Missed Change	Coverage	Master Coverage	Coverage Change
Lines	71790	14634	14551	83	79.62%	79.73%	-.11%
Functions	6455	1356	1353	3	78.99%	79.04%	-.05%
Regions	44841	13003	12982	21	71.00%	71.04%	-.04%
Branches	24386	7107	7089	18	70.86%	70.93%	-.07%

This PR adds/edits 62 newly uncovered lines.

Artifacts

• HTML Coverage Report and Diff
• File Coverage Summary
• Diff Text File
• Full Text Coverage Report
• Python Coverage Report

Commit Hashes

• 125e062

[therock-pr-bot]

✅ All Checks Passed — Ready for Review

Check	Status	Details
📝 PR Description	✅ Pass	—
⛔ Forbidden Files	✅ Pass	—
🧪 Unit Test	⚠️ Warning	Error: Source/code files changed without an accompanying unit test. Expected: add at least one test file named like test_<name>.py / test_<name>.cpp (or <name>_test.*). Current: code file(s) changed: shared/rocroller/lib/source/Assemblers/InProcessAssembler.cpp; no test file found
🔎 pre-commit	✅ Pass	—
🚫 Draft PR	🔜 To Be Enabled	—
🚩 Feature Flag	🔜 To Be Enabled	—
📊 Code Coverage	🔜 To Be Enabled	—
🤖 therock-pr-bot	✅ Pass	—

🎉 All checks passed! This PR is ready for review.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

[therock-pr-bot]

🎉 All checks passed! This PR is ready for review.

[assistant-librarian]

TheRock Submodule Bump Activity

Newest first

• 2026-11-05 — Included in TheRock via ROCm/TheRock#9736.