Repository navigation
fix(hipdnn): keep the ingestor-engine runbook link inside the skill - #14618
Merged
GarbyGilbertAMD merged 1 commit intoOct 28, 2026
Merged
Conversation
The hipdnn-ingestor-engine runbook linked to the hipDNN environment documentation with a relative path that leaves the skill directory. Installing a skill copies only its own directory, so the link dangled in every installed copy, and validate-skills.py rejected it. The reference now names HIPDNN_FORCE_BENCHMARKING in projects/hipdnn/docs/Environment.md as a repository path, the form the runbook already uses for other hipDNN documents. ALMIOPEN-2876
github-actions
Bot
added
documentation
ci:docs-only
GarbyGilbertAMD
marked this pull request as ready for review
October 28, 2026 21:43
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
BrianHarrisonAMD
approved these changes
Oct 28, 2026
GarbyGilbertAMD
deleted the
users/ggilbert/ALMIOPEN-2876/fix-runbook-link
branch
October 28, 2026 21:49
Contributor
TheRock Submodule Bump ActivityNewest first
|
3 of 4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#14463 added a link from the
hipdnn-ingestor-enginerunbook toprojects/hipdnn/docs/Environment.mdthrough../../../../docs/, a path that leaves the skill directory. Installing a skill copies only that directory, so the link dangles in every installed copy, andvalidate-skills.pyrejects it: ondevelopthe validator exits 1 andtest_committed_skills_validate_cleanfails. No CI job runs either check. This PR names the same section as a repository path, the form the runbook already uses for other hipDNN documents.JIRA ID : ALMIOPEN-2876
Risk Assessment
Risk 1. One line of Markdown in a skill runbook; no code, build, test or packaging change.
Testing Summary
test_committed_skills_validate_cleanfails ondevelopwithlink target '../../../../docs/Environment.md#hipdnn_force_benchmarking' escapes the installed skill root 'hipdnn-ingestor-engine/'and passes with this change.projects/...path exists, so the new reference is checked.Testing Checklist
python projects/hipdnn/tools/ai/validate-skills.py- Status: Passed (16 skills)pytest projects/hipdnn/tools/ai/tests/test_skills_tooling.py- Status: Passed (32)Technical Changes
projects/hipdnn/tools/ai/skills/hipdnn-ingestor-engine/RUNBOOK.md(stage 6, Catalog size): the Markdown link toEnvironment.md#hipdnn_force_benchmarkingbecomesHIPDNN_FORCE_BENCHMARKINGinprojects/hipdnn/docs/Environment.md.