Repository navigation
fix(hipblaslt): order solution keys while preserving argument versions - #14615
Draft
ThanHenderson wants to merge 2 commits into
Draft
ThanHenderson wants to merge 2 commits into
ThanHenderson wants to merge 2 commits into
Conversation
github-actions
Bot
added
project: hipblaslt
project: hipsparselt
ci:hipsparselt-fast
labels
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #14615 +/- ##
===========================================
- Coverage 77.35% 77.28% -0.06%
===========================================
Files 2893 2893
Lines 485890 485742 -148
Branches 73442 73414 -28
===========================================
- Hits 375816 375405 -411
- Misses 85263 85579 +316
+ Partials 24811 24758 -53
*This pull request uses carry forward flags. Click here to find out more.
🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA ID : AIHPBLAS-5250
Motivation
The execution-policy normalization introduced in #12537 rebuilds solution dictionaries during merging, changing their key order. Geko edits can also append keys outside the expected order.
This restores the ordering fix from #14195, reverted in #14565, while preserving explicit kernel-argument versions.
Technical Details
KernArgsVersionfiltering introduced in #11923 fromreorderSolutionDictForDictMerge. The existing helper now preserves every field and value. Its library-generation and list-to-dict conversion callers also retain explicit versions.InternalSupportParamskeys are sorted.Test Plan
Run the affected TensileLite unit modules (
test_LibraryIO.pyandtest_TensileMergeLibrary.py), their characterization suites, and geko’stest_library_unit.py.Cover real renaming, explicit and missing argument versions, key ordering, and input immutability. Compare a self-merge of an existing gfx90a library logic file against develop and run pre-commit on the changed files.
Test Result
Submission Checklist
Risk level
Low: changes are confined to serialization and merge output. Explicit argument versions now remain explicit in generated and converted logic, with regression tests covering their preservation.