Repository navigation
feat(ci): skip TheRock CI for changes to non-TheRock workflows - #14584
Merged
geomin12 merged 3 commits intoOct 28, 2026
Merged
Conversation
Editing a workflow like pre-commit.yml, labeler.yml or one of the component-ci jobs cannot change the outcome of a TheRock build or test, yet every such PR currently spins up the full multi-arch matrix. Add the 36 non-therock-* workflow files to the skip-ci patterns so those runners are left for work that actually needs them. fnmatch has no negation operator, so the list is enumerated by hand rather than expressed as "everything but therock-*". The therock-* workflows are deliberately excluded and must keep triggering CI so that changes to the CI definition itself are validated. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The skip-CI config only gates which workflows run; it is not an input to any build or test, so editing it cannot change a TheRock result. Note this is self-referential: the config is read from the PR head, so a PR touching only this file now skips its own CI. That is intended, but it means review is the sole guard against a bad pattern here silently un-gating CI for everything downstream. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
❌ PR Check — Action Required
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🚫 Please fix the failed policies before requesting reviews. The following policy checks failed:
The |
dysu-amd
approved these changes
Oct 28, 2026
| # | ||
| # fnmatch has no negation operator, so this list must be maintained by hand. | ||
| # IMPORTANT: never add ".github/workflows/therock-*" here -- those workflows | ||
| # define TheRock CI itself and must always re-run it to validate the change. |
Contributor
There was a problem hiding this comment.
nit: I feel the IMPORTANT note here is redundant, the first paragraph already says that these are "Workflows that are not TheRock CI"
Also the note about fnmatch functionality could be moved to line 10 of this file if really needed, instead of buried down here as a therock-workflow-specific comment.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
geomin12
deleted the
users/geomin12/ignore-ci-for-irrelevant-workflows
branch
October 28, 2026 19:49
Contributor
TheRock Submodule Bump ActivityNewest first
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doing explicit
skip-ciinskip-ci.toml, so when these workflow(s) are touched, it is ignored by TheRock CI.This way, it is clear to rocm-libraries folks that this is skipped and why it was (rather than assumed TheRock behavior)