Repository navigation
feat(stinkytofu): warn in the debug output when a ds stage is too sparse for the LDS rate - #14535
Merged
Merged
Conversation
…rse for the LDS rate When a stage's loads need more WMMAs at DsReadCyclesPerLoad than the stage has, the LDS rate can not finish them by the stage end and the last ds_load lands late. The pacer now records such stages (DsSpreadPacer::rateLimited) and the DAG scheduler prints one [CDNA5 dsSpread] WARNING per stage in the pass debug output. The plan is unchanged. Unit tests: the stage is recorded when the rate does not fit and not otherwise, and the warning text is checked.
github-actions
Bot
added
project: hipblaslt
project: hipsparselt
shared: stinkytofu
labels
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
geotseng-amd
approved these changes
Oct 28, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #14535 +/- ##
===========================================
- Coverage 77.29% 77.29% -0.00%
===========================================
Files 2889 2889
Lines 484711 484711
Branches 73195 73195
===========================================
- Hits 374634 374629 -5
- Misses 85355 85358 +3
- Partials 24722 24724 +2
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
Contributor
TheRock Submodule Bump ActivityNewest first
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA ID : AIHPBLAS-5348
Follow-up to #14531.
Problem
When a ds_load stage's loads need more WMMAs at
DsReadCyclesPerLoadthan the stage has, the LDS rate cannot finish them by the stage end and the last ds_load lands late. Nothing in the pass output says so, so aDsReadCyclesPerLoadset too high looks like a scheduler bug.Change
DsSpreadPacer::planrecords each such stage (rateLimited(): start, end, load count, WMMAs needed). The plan itself is unchanged.[CDNA5 dsSpread] WARNINGline per recorded stage underPASS_DEBUG, naming the stage, the rate and the shortfall. Release builds and the generated asm are not affected.Tests
DsSpreadPacer: a stage is recorded when the rate does not fit its end, and not when it fits or when no rate is given.DsSpreadPacer: the warning text is checked exactly (rateLimitedMessage).