Skip to content

fix(rocthrust): resolve test failures in rocthrust hipccl 3.2 - #14467

Merged
amd-jmahovsky merged 4 commits into
users/amd-jmahovsky/hipccl/rocthrust_cccl32from
users/naraenda/fix-rocthrust-cccl32
Nov 4, 2026
Merged

fix(rocthrust): resolve test failures in rocthrust hipccl 3.2#14467
amd-jmahovsky merged 4 commits into
users/amd-jmahovsky/hipccl/rocthrust_cccl32from
users/naraenda/fix-rocthrust-cccl32

Conversation

@Naraenda

@Naraenda Naraenda commented Oct 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Motivation

Fixes two test found after #13963.

Technical Details

  • a6eccea updates a test that was missed in the preceding PR.
  • 2736c6c resolves an issue that highlighted an issue where expected behavior in reduce by key is different between hipCUB and rocThrust.

Test Plan

Build and test with libhipcxx 3.4.

Test Result

Works on my machine.

Submission Checklist

@Naraenda
Naraenda added this pull request to stack #14381 October 27, 2026 15:01
@Naraenda
Naraenda marked this pull request as ready for review October 27, 2026 15:03
@Naraenda
Naraenda requested a review from a team as a code owner October 27, 2026 15:03
@therock-pr-bot

therock-pr-bot Bot commented Oct 27, 2026

Copy link
Copy Markdown

❌ PR Check — Action Required

Check Status Details
📝 PR Description ❌ Fail Error: PR description must reference a JIRA ID, ISSUE ID, or a GitHub closing keyword.
Expected: include a JIRA ID / ISSUE ID line (separator : or -, or omitted; value may be a JIRA key, a number with/without #, or a link), OR a closing keyword + issue reference. Accepted examples:
• JIRA ID : TESTAUTO-6039
• JIRA ID - #330
• JIRA ID #330
• JIRA ID (on separate line)
ROCM-25757
• ISSUE ID : TESTUTO-3334
• ISSUE ID #3334
• ISSUE ID - TESTAUTO-3433
• ISSUE ID (on separate line)
AIRUNTIME-2352
• ISSUE ID : https://github.com/<org_name>/<repo_name>/issues/1234
• Closes #10
• Fixes octo-org/octo-repo#100
• Resolves: #123
• #123
• https://github.com/<org_name>/<repo_name>/issues/123
Current: no valid JIRA/ISSUE/closing-keyword reference found
⛔ Forbidden Files ✅ Pass —
🧪 Unit Test ✅ Pass —
🔎 pre-commit ✅ Pass —
🚫 Draft PR 🔜 To Be Enabled —
🚩 Feature Flag 🔜 To Be Enabled —
📊 Code Coverage 🔜 To Be Enabled —

⚠️ 1 policy check(s) failed. Please address the issues above before this PR can be Reviewed.

🚫 Please fix the failed policies

  • ❌ PR Description

The Not ready to Review label was added to this PR. Once all policies pass, the label is removed automatically.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@therock-pr-bot

therock-pr-bot Bot commented Oct 27, 2026

Copy link
Copy Markdown

🚫 Please fix the failed policies before requesting reviews.

The following policy checks failed:

  • ❌ PR Description

The Not ready to Review label has been added to this PR.
Once all policies pass, the label will be removed automatically.

@assistant-librarian assistant-librarian Bot added the organization: streamhpc contributors from streamhpc label Oct 27, 2026
@Naraenda
Naraenda removed this pull request from stack #14381 October 29, 2026 08:52
@Naraenda
Naraenda force-pushed the users/amd-jmahovsky/hipccl/rocthrust_cccl32 branch from 8834f3f to 7e110ef Compare October 29, 2026 13:18
@Naraenda
Naraenda requested a review from a team as a code owner October 29, 2026 13:18
@Naraenda Naraenda mentioned this pull request Oct 29, 2026
Open
1 task
@Naraenda
Naraenda force-pushed the users/naraenda/fix-rocthrust-cccl32 branch from a6eccea to ffe5db6 Compare October 29, 2026 13:22
@Naraenda
Naraenda force-pushed the users/amd-jmahovsky/hipccl/rocthrust_cccl32 branch from 7e110ef to ef5d8c2 Compare October 29, 2026 16:20
@amd-jmahovsky
amd-jmahovsky force-pushed the users/amd-jmahovsky/hipccl/rocthrust_cccl32 branch from ef5d8c2 to 6263bbe Compare October 29, 2026 16:46
@Naraenda
Naraenda force-pushed the users/amd-jmahovsky/hipccl/rocthrust_cccl32 branch from 6263bbe to 7bd4dfc Compare October 30, 2026 09:41
@Naraenda
Naraenda force-pushed the users/naraenda/fix-rocthrust-cccl32 branch from ffe5db6 to e6f18d8 Compare October 30, 2026 10:00
@Naraenda @NB4444
feat(rocthrust): port copy changes to hip
d386205 
Co-authored-by: Nick <nick@streamhpc.com>
@Naraenda Naraenda mentioned this pull request Oct 30, 2026
Closed
1 task done
amd-jmahovsky
amd-jmahovsky approved these changes Nov 3, 2026
View reviewed changes

@amd-jmahovsky amd-jmahovsky left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@umfranzw umfranzw mentioned this pull request Nov 4, 2026
Open
1 task
@amd-jmahovsky
amd-jmahovsky merged commit 10cec77 into users/amd-jmahovsky/hipccl/rocthrust_cccl32 Nov 4, 2026
311 of 319 checks passed
@amd-jmahovsky
amd-jmahovsky deleted the users/naraenda/fix-rocthrust-cccl32 branch November 4, 2026 16:22
amd-jmahovsky added a commit that referenced this pull request Nov 4, 2026
@amd-jmahovsky @claude
fix(rocthrust): drop include of removed hip/detail/par_to_seq.h in co…
1d5920e 
…py.h

par_to_seq.h was folded into hip/detail/execution_policy.h by the CCCL 3.2
ADDITIONAL changes (#14670), while #14467 added an include of it to copy.h.
copy.h already includes hip/detail/execution_policy.h, which provides
cvt_to_seq.

Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amd-jmahovsky amd-jmahovsky amd-jmahovsky approved these changes

Assignees

@Naraenda Naraenda

@NB4444 NB4444

Labels

Not ready to Review organization: streamhpc contributors from streamhpc project: hipccl project: rocprim project: rocthrust

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Naraenda @amd-jmahovsky @NB4444