Repository navigation
fix(rocBLAS) : allow empty strings to pass rocblas_get_ - #14380
Merged
Merged
Conversation
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #14380 +/- ##
===========================================
- Coverage 77.26% 77.19% -0.07%
===========================================
Files 2892 2888 -4
Lines 485320 483818 -1502
Branches 73315 73014 -301
===========================================
- Hits 374938 373449 -1489
- Misses 85631 85750 +119
+ Partials 24751 24619 -132
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
TorreZuk
force-pushed
the
users/torrezuk/rocm-33491-fix-ver-test
branch
from
October 27, 2026 15:51
d359e21 to
4c2cd94
Compare
TorreZuk
force-pushed
the
users/torrezuk/rocm-33491-fix-ver-test
branch
from
October 27, 2026 20:42
4c2cd94 to
c03b34e
Compare
assistant-librarian Bot
pushed a commit
to ROCm/rocBLAS
that referenced
this pull request
Oct 29, 2026
fix(rocBLAS) : allow empty strings to pass rocblas_get_ (#14380) ## Motivation This pull request makes minor improvements to the unit tests for string retrieval functions in `general_gtest.cpp`. The main focus is on clarifying buffer size expectations and ensuring proper handling of empty strings. Test robustness and clarity improvements: * Updated the assertion in `expect_get_string_rejects_short_buffer` to check that the size is greater than 0 (instead of 1), with a clarifying comment about the string termination character. * Added a conditional so the buffer test is only run if the size is greater than 0, preventing unnecessary operations for empty strings. * Added a comment noting that the commit hash string may be empty, clarifying expectations for related tests. JIRA ID : ROCM-33491 Co-authored-by: renjithravindrankannath <94420380+renjithravindrankannath@users.noreply.github.com>
Contributor
TheRock Submodule Bump ActivityNewest first
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This pull request makes minor improvements to the unit tests for string retrieval functions in
general_gtest.cpp. The main focus is on clarifying buffer size expectations and ensuring proper handling of empty strings.Test robustness and clarity improvements:
expect_get_string_rejects_short_bufferto check that the size is greater than 0 (instead of 1), with a clarifying comment about the string termination character.JIRA ID : ROCM-33491