Repository navigation
fix(hipblaslt): Load the RNDseed value into the sgpr when using software rounding - #14337
Merged
Merged
Conversation
github-actions
Bot
added
project: hipblaslt
project: hipsparselt
ci:hipsparselt-fast
labels
pmckinno
force-pushed
the
users/pmckinno/stochastic_rounding_mi300
branch
2 times, most recently
from
October 23, 2026 22:05
a87c248 to
1ba9785
Compare
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
msujon-AMD
approved these changes
Oct 23, 2026
AlexBrownAMD
approved these changes
Oct 23, 2026
pmckinno
force-pushed
the
users/pmckinno/stochastic_rounding_mi300
branch
from
October 23, 2026 23:07
1ba9785 to
ff09e3d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #14337 +/- ##
=========================================
Coverage 75.91% 75.91%
=========================================
Files 2883 2884 +1
Lines 480800 480964 +164
Branches 72335 72368 +33
=========================================
+ Hits 364994 365122 +128
- Misses 90769 90798 +29
- Partials 25037 25044 +7
*This pull request uses carry forward flags. Click here to find out more.
🚀 New features to boost your workflow:
|
pmckinno
force-pushed
the
users/pmckinno/stochastic_rounding_mi300
branch
from
October 26, 2026 15:31
ff09e3d to
48f1598
Compare
…are rounding On architectures without v_prng_b32, the random seed was defined but never written. JIRA ID: AIHPBLAS-5267
pmckinno
force-pushed
the
users/pmckinno/stochastic_rounding_mi300
branch
from
October 26, 2026 15:44
48f1598 to
06733d4
Compare
Contributor
TheRock Submodule Bump ActivityNewest first
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
##Motivation
On architectures without v_prng_b32, the random seed was defined but never written.
JIRA ID: AIHPBLAS-5267