Repository navigation
fix(hipdnn): give the IngestorGenerator ctest entry the hipcc HIP resolved - #14209
Merged
Merged
Conversation
…olved test_verify_variant_sets_multi_launch_rocke.py (#14158) packs with the real compiler and fails without hipcc. The suite became a ctest entry in #13385, which was last tested before #14158 merged. The Windows superbuild lane puts the ROCm bin directory on PATH, the Linux lane does not, so all four cases error at setup there. Pass HKP_HIPCC from find_package(hip), as the descriptor-packaging ctest entries already do.
GarbyGilbertAMD
approved these changes
Oct 22, 2026
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
13 tasks done
Contributor
TheRock Submodule Bump ActivityNewest first
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
hipdnn_ingestor_generator_pytestfailure on the Linux hipDNN Superbuild lane. The ctest entry now passesHKP_HIPCC, so the multi-launch rocKE tests from #14158 find the compiler. Before this change they found it only when hipcc was onPATH, which is true on Windows but not on Linux.JIRA ID : ALMIOPEN-2973
Related: #14158 added the test; #13385 made the suite a superbuild ctest entry. Each PR passed its own CI; the failure appears only with both merged.
Risk Assessment
Risk 1 of 5. The change only sets an environment variable on one test entry. That entry is registered only when
HIPDNN_ENABLE_TOOLING_TESTS=ON, which only superbuild CI turns on.ASIC Coverage
Host-only test wiring with no device code. Passing PR CI is sufficient.
Testing Summary
test_verify_variant_sets_multi_launch_rocke.pyreproduce the CI error without hipcc and pass withHKP_HIPCCset.HKP_HIPCCinto the test's environment in the generated ctest file.Testing Checklist
pytest tests/test_verify_variant_sets_multi_launch_rocke.pywithPATH=/usr/bin:/bin- Status: 4 errors (hipcc not found), matching CIHKP_HIPCC=/opt/rocm/bin/hipcc- Status: Passed (4)projects/hipdnnwithHIPDNN_ENABLE_KERNEL_INGESTOR=ONandHIPDNN_ENABLE_TOOLING_TESTS=ON- Status:HKP_HIPCCset onhipdnn_ingestor_generator_pytestTechnical Changes
find_package(hip)resolves, the same source the descriptor-packaging ctest entries use. The alternative, putting the ROCm bin directory onPATHin the Linux workflow, would change the environment of every Linux test.