Repository navigation
fix(hipsparse): destroy hipsparse handle during unwind - #14122
Merged
jsandham merged 14 commits intoOct 25, 2026
Merged
Conversation
A failed hipsparseCreate in handle_struct is reported by an assertion that returns from the verifier, so the wrapper can still be constructed with an uninitialized handle. These tests now use hipsparseLocalHandle_t, which throws on creation failure and destroys the handle when the test unwinds.
A failed hipsparseCreate in handle_struct is reported by an assertion that returns from the verifier, so the wrapper can still be constructed with an uninitialized handle. These tests now use hipsparseLocalHandle_t, which throws on creation failure and destroys the handle when the test unwinds.
A failed hipsparseCreate in handle_struct is reported by an assertion that returns from the verifier, so the wrapper can still be constructed with an uninitialized handle. These tests now use hipsparseLocalHandle_t, which throws on creation failure and destroys the handle when the test unwinds.
A failed hipsparseCreate in handle_struct is reported by an assertion that returns from the verifier, so the wrapper can still be constructed with an uninitialized handle. These tests now use hipsparseLocalHandle_t, which throws on creation failure and destroys the handle when the test unwinds.
A failed hipsparseCreate in handle_struct is reported by an assertion that returns from the verifier, so the wrapper can still be constructed with an uninitialized handle. These tests now use hipsparseLocalHandle_t, which throws on creation failure and destroys the handle when the test unwinds.
A failed hipsparseCreate in handle_struct is reported by an assertion that returns from the verifier, so the wrapper can still be constructed with an uninitialized handle. These tests now use hipsparseLocalHandle_t, which throws on creation failure and destroys the handle when the test unwinds.
A failed hipsparseCreate in handle_struct is reported by an assertion that returns from the verifier, so the wrapper can still be constructed with an uninitialized handle. These tests now use hipsparseLocalHandle_t, which throws on creation failure and destroys the handle when the test unwinds.
All client tests now use hipsparseLocalHandle_t, so the assertion-based handle_struct owner is no longer needed. Co-authored-by: Cursor <cursoragent@cursor.com>
jsandham
changed the title
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
jsandham
changed the title
Co-authored-by: Cursor <cursoragent@cursor.com>
2 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #14122 +/- ##
===========================================
+ Coverage 75.84% 75.93% +0.10%
===========================================
Files 2881 2873 -8
Lines 479150 477006 -2144
Branches 72006 71572 -434
===========================================
- Hits 363369 362207 -1162
+ Misses 90863 90102 -761
+ Partials 24918 24697 -221
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
ntrost57
reviewed
Oct 22, 2026
ntrost57
reviewed
Oct 22, 2026
ntrost57
approved these changes
Oct 22, 2026
amontoison
approved these changes
Oct 22, 2026
… fix/hipsparse-local-handle-tests
Contributor
TheRock Submodule Bump ActivityNewest first
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
hipsparseLocalHandle_t.Arguments.handle_structwrapper.Test Plan
hipsparse-test.JIRA ID: AISPARSE-891