Skip to content

[rpp] link half publicly #13951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
afzpatel merged 3 commits into from
Oct 26, 2026
Merged

[rpp] link half publicly #13951

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6d432ec
[rpp] link half publicly
afzpatel Oct 19, 2026
381e598
add find_dependency(half) to rpp config
afzpatel Oct 21, 2026
5b101df
add review suggestions
afzpatel Oct 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions projects/rpp/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,10 +392,9 @@ endif()

message("-- ${White}${PROJECT_NAME} -- Using Compiler - Path:" ${CMAKE_CXX_COMPILER} "\tVersion:" ${CMAKE_CXX_COMPILER_VERSION} "\tCompiler:" ${CMAKE_CXX_COMPILER_ID}${ColourReset})
message("-- ${White}${PROJECT_NAME} -- CMAKE_CXX_FLAGS:${CMAKE_CXX_FLAGS}${ColourReset}")
target_link_libraries(${PROJECT_NAME} PRIVATE
OpenMP::OpenMP_CXX
HALF::half
)
target_link_libraries(${PROJECT_NAME} PRIVATE OpenMP::OpenMP_CXX)
target_include_directories(${PROJECT_NAME} PUBLIC $<BUILD_INTERFACE:${HALF_INCLUDE_DIRS}>)

if(RPP_HIP_HOST_TARGET)
target_link_libraries(${PROJECT_NAME} PUBLIC ${RPP_HIP_HOST_TARGET})
endif()
Expand Down
9 changes: 9 additions & 0 deletions projects/rpp/cmake_modules/rpp-config.cmake.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,15 @@ if(NOT TARGET @PROJECT_NAME@::@PROJECT_NAME@)
endif()
endif ()

find_path(@PROJECT_NAME@_HALF_INCLUDE_DIR
NAMES half/half.hpp half.hpp
HINTS "${PACKAGE_PREFIX_DIR}/include" "$ENV{ROCM_PATH}/include")
mark_as_advanced(@PROJECT_NAME@_HALF_INCLUDE_DIR)
if(@PROJECT_NAME@_HALF_INCLUDE_DIR)
set_property(TARGET @PROJECT_NAME@::@PROJECT_NAME@ APPEND PROPERTY
INTERFACE_INCLUDE_DIRECTORIES "${@PROJECT_NAME@_HALF_INCLUDE_DIR}")
endif()

include(FindPackageHandleStandardArgs)
find_package_handle_standard_args(
@PROJECT_NAME@
Expand Down
Loading