Repository navigation
fix(rocprim): Add proper gfx950 config support, and fix launch_manager wavefront support (legacy) - #13881
Merged
stanleytsang-amd merged 1 commit intoOct 17, 2026
Conversation
…r wavefront support launch_manager dropped the wavefront size chosen by visit_config for fallback configs. The host then instantiated trampoline_kernel with a `dynamic` wavefront, while the gfx950 code object only contains the size64 instantiation, giving "Cannot find Symbol" at runtime (rocprim.linking). Pass the wavefront explicitly to launch_manager in the fallback branch. Also remove gfx950 from ROCPRIM_IS_CDNA3 (it is CDNA4 only) and add mi355x. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
⏳ Waiting on Required Checks⏳ Required checks have not all concluded yet. This bot run is exiting without failing so those checks can report independently.
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
⏳ Waiting for required checks to start or finish:
|
stanleytsang-amd
deleted the
users/stanleytsang-amd/fix-gfx950-configs-rocprim-legacy
branch
October 17, 2026 03:33
Contributor
TheRock Submodule Bump ActivityNewest first
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Issue: #13871
Motivation
Legacy `projects/rocprim` has the same bug fixed for hipccl3 in #13251. `rocprim.linking` fails in TheRock CI on gfx950 (https://github.com/ROCm/TheRock/actions/runs/38904910579) with:
`hip_global.cpp: Cannot find Symbol with name: _ZN7rocprim17ROCPRIM_400800_NS6detail17trampoline_kernelI...launch_manager...`
gfx950 config support also needed fixing: it was listed as both CDNA4 and CDNA3, and MI355X was not supported.
Technical Details
`visit_config` resolves size64/size32 for the fallback (dynamic wavefront) target, but `launch_manager::make_launch_plan` ignored it and called `trampoline_kernel<..., Target, LaunchSelector>`, so `TargetWaveSize` fell back to `get_wavefront_size(Target::g)`. For the fallback target that is `dynamic` in the host pass but a concrete size in the gfx950 device pass, so the host looked up a kernel symbol that is not in the code object.
Test Plan
Rerun `rocprim.linking` and the rocPRIM tests on gfx950 in CI. Not built or tested locally.
🤖 Generated with Claude Code