Skip to content

Skip i128 in test_device_transform.cpp if unsupported.#1380

Closed
marbre wants to merge 1 commit into
developfrom
users/marbre/rocprim-i128
Closed

Skip i128 in test_device_transform.cpp if unsupported.#1380
marbre wants to merge 1 commit into
developfrom
users/marbre/rocprim-i128

Conversation

@marbre
Copy link
Copy Markdown
Member

@marbre marbre commented Aug 27, 2025

@marbre marbre requested a review from a team as a code owner August 27, 2025 21:50
@stanleytsang-amd
Copy link
Copy Markdown
Contributor

I'm not quite sure I understand, didn't we fix this properly with #1029 ?

@marbre
Copy link
Copy Markdown
Member Author

marbre commented Aug 27, 2025

I'm not quite sure I understand, didn't we fix this properly with #1029 ?

We carried this patch before and #1029 was needed in addition. However, I can try to drop this patch to check if #1029 is sufficient.

@marbre
Copy link
Copy Markdown
Member Author

marbre commented Aug 28, 2025

#1029 is indeed sufficient to fix the build failure, so this won't be needed.

@marbre marbre closed this Aug 28, 2025
@marbre marbre deleted the users/marbre/rocprim-i128 branch August 28, 2025 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants