Repository navigation
Revert "fix(hipblaslt): correct MI300A kernel selection in the WGMXCC predicate and KD-tree search" - #13479
Merged
arjun-raj-kuppala merged 1 commit intoOct 12, 2026
Conversation
… predica…" This reverts commit 299016a.
github-actions
Bot
added
project: hipblaslt
project: hipsparselt
ci:hipsparselt-fast
labels
⏳ Waiting on Required Checks⏳ Required checks have not all concluded yet. This bot run is exiting without failing so those checks can report independently.
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
⏳ Waiting for required checks to start or finish:
|
TriveniTadapaneni
marked this pull request as ready for review
October 12, 2026 07:06
arjun-raj-kuppala
self-requested a review
October 12, 2026 07:33
arjun-raj-kuppala
deleted the
revert-13293-users/nelumala/hipBLASLt/mi300a-wgmxcc-predicate
branch
October 12, 2026 07:39
Contributor
TheRock Submodule Bump ActivityNewest first
|
NaveenElumalaiAMD
added a commit
that referenced
this pull request
Oct 14, 2026
…te and KD-tree search- #13293 (#13586) ## Motivation MI300A is locked out of nearly all the generic gfx942 (MI300X) kernels: **150,639 of 195,438** solutions (77.1%; 99.7% of GridBased) are rejected before ranking at 228 CUs, so SGEMM NT collapses onto a handful of tiles and fp8/bf8 fall back to a single tile per transpose combo. This PR lets MI300A use the full MI300X kernel set, and re-lands #13293 (reverted by #13479) with **only the code changes** — both `clients/tests/data` YAML commits are dropped. ## Technical Details Generic gfx942 solutions carry `WorkGroupMappingXCCGroup: -1`, so `WorkgroupMappingXCCCheck` substitutes `cuCount` (228) and rejects them because `228 % XCC != 0`. They are CU-fallbacks that already launch at `WGMXCC=1` (`setWGMXCC(isCUFallback ? 1 : 0)`), but the predicate runs before `setFallbackStatus()` marks them — `isMI300A()` closes that gap by evaluating the check at `XCC=1`. Net **2 files, +59/−6**, provably inert off MI300A (`fallbackXCC()` reduces to the original `fallbackStatus()` when `isMI300A()` is false); also guards the KD-tree batch search against empty cells (`PropertyMatching.hpp`). ## Test Plan Built against `develop` @ `b5c1c01faf3` on MI300A (gfx942, 228 CU) and ran `hipblaslt-test` plus CPU-verified `hipblaslt-bench` SGEMM NT at 8192³, 4096³ and 2048×8192×8192. The predicate change was previously swept over 3189 SGEMM NT shapes against #12609 with the KD-tree held equal between arms. ## Test Result Admitted SGEMM NT solutions on MI300A go from **97 of 8192 (1.2%) to all 8192**, and the distinct kernels actually selected across the 3189-shape sweep rise **44 → 756** — no longer collapsing onto `MT128x128x32` for a third of shapes. Selection matches #12609 on **3188/3189** shapes, delivering that PR's 353 MB of 228-CU tuning logic as code rather than data; `hipblaslt-test` **57/57 passed** and all three shapes verify against CPU (8192³ at 88.2 TFLOPS, `norm_error` 1.36527e-06). The 97→8192 and 44→756 figures come from the earlier canonical launch-site dump and 3189-shape sweep, not from this session's build — my attempted differential re-check here didn't discriminate, as I noted. The correctness numbers (57/57, 88.2 TFLOPS, norm_error) are from this session.
TriveniTadapaneni
added
the
bump-pr-revert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #13293
Fix issue :#13480
test run passed: https://github.com/ROCm/TheRock/actions/runs/38203742146/job/114696224272