test(rocsparse): add unit tests for 80% unit-only coverage (AISPARSE-879)

projects/rocsparse/.jenkins/common.groovy

@@ -203,6 +203,15 @@ def runCoverageCommand (platform, project, gfilter, String dirmode = "release")
                     GTEST_LISTENER=NO_PASS_LINE_IN_LOG ./clients/staging/rocsparse-unit-test-device --gtest_output=xml:test_detail_unit_device.xml --gtest_color=yes
                     GTEST_LISTENER=NO_PASS_LINE_IN_LOG make coverage_cleanup coverage GTEST_FILTER=${gfilter}-*known_bug*
                     /usr/local/bin/codecov -v -U \$http_proxy -t ${CODECOV_TOKEN} --file coverage-report/coverage.info --name rocm-libraries --flags rocSPARSE --sha ${commitSha}
+                    # Also report the unit tests and rocsparse-test as separate flags. Upload only if
+                    # coverage_split succeeded, so a stale or partial file is never sent; a failure here
+                    # must not fail the job.
+                    if make coverage_split; then
+                        /usr/local/bin/codecov -v -U \$http_proxy -t ${CODECOV_TOKEN} --file coverage-report/coverage-unit.info --name rocm-libraries-unit --flags rocSPARSE-unit --sha ${commitSha} || true
+                        /usr/local/bin/codecov -v -U \$http_proxy -t ${CODECOV_TOKEN} --file coverage-report/coverage-integration.info --name rocm-libraries-integration --flags rocSPARSE-integration --sha ${commitSha} || true
+                    else
+                        echo "coverage_split failed; rocSPARSE-unit and rocSPARSE-integration not uploaded"
+                    fi
                 """
 
         platform.runCommand(this, command)

projects/rocsparse/CMakeLists.txt

@@ -417,16 +417,18 @@ if(BUILD_CODE_COVERAGE)
   add_custom_target(coverage_analysis
     COMMAND ${CMAKE_COMMAND} -E make_directory ./coverage-report/profraw
     COMMAND echo Coverage GTEST_FILTER=\${GTEST_FILTER}
-    COMMAND ${CMAKE_COMMAND} -E env LLVM_PROFILE_FILE="./coverage-report/profraw/rocsparse-coverage_%m.profraw" ./clients/staging/rocsparse-test --gtest_filter=\"\${GTEST_FILTER}\"
+    COMMAND ${CMAKE_COMMAND} -E env LLVM_PROFILE_FILE="./coverage-report/profraw/rocsparse-coverage_integration_%m.profraw" ./clients/staging/rocsparse-test --gtest_filter=\"\${GTEST_FILTER}\"
     # Also fold in the standalone unit-test binaries so their host-side coverage
     # of librocsparse is counted. The %m module hash keeps profraw names distinct
-    # per binary; they match the rocsparse-coverage_*.profraw merge glob below.
+    # per binary. The integration (rocsparse-test) and unit-test files use different
+    # prefixes so coverage_split can report them separately; all of them still match
+    # the rocsparse-coverage_*.profraw merge glob below.
     # make exports GTEST_FILTER into the recipe environment and gtest honors it,
     # which previously selected 0 host tests and 6 device tests. These binaries
     # are not categorized that way, so run each suite in full. || true keeps a
     # unit-test failure from aborting the coverage upload.
-    COMMAND sh -c "env -u GTEST_FILTER LLVM_PROFILE_FILE=./coverage-report/profraw/rocsparse-coverage_%m.profraw ./clients/staging/rocsparse-unit-test --gtest_filter='*' || true"
-    COMMAND sh -c "env -u GTEST_FILTER LLVM_PROFILE_FILE=./coverage-report/profraw/rocsparse-coverage_%m.profraw ./clients/staging/rocsparse-unit-test-device --gtest_filter='*' || true"
+    COMMAND sh -c "env -u GTEST_FILTER LLVM_PROFILE_FILE=./coverage-report/profraw/rocsparse-coverage_unit_%m.profraw ./clients/staging/rocsparse-unit-test --gtest_filter='*' || true"
+    COMMAND sh -c "env -u GTEST_FILTER LLVM_PROFILE_FILE=./coverage-report/profraw/rocsparse-coverage_unit_%m.profraw ./clients/staging/rocsparse-unit-test-device --gtest_filter='*' || true"
     WORKING_DIRECTORY ${CMAKE_BINARY_DIR}
     )
 
@@ -514,11 +516,41 @@ if(BUILD_CODE_COVERAGE)
     WORKING_DIRECTORY ${CMAKE_BINARY_DIR}
   )
 
+  # Report the unit tests and the rocsparse-test (integration) client separately,
+  # from the profiles that coverage_analysis already wrote. This does not run any
+  # test. It only merges and exports subsets of the same profraw files.
+  # > make coverage_split (after make coverage)
+  # writes coverage-report/coverage-unit.info and coverage-integration.info.
+  foreach(_split unit integration)
+    if(Python3_FOUND AND EXISTS ${COVERAGE_FILTER_SCRIPT})
+      set(_split_filter_${_split}
+        COMMAND ${Python3_EXECUTABLE} ${COVERAGE_FILTER_SCRIPT} ./coverage-report/coverage-${_split}-raw.info ./coverage-report/coverage-${_split}.info)
+    else()
+      set(_split_filter_${_split}
+        COMMAND ${CMAKE_COMMAND} -E copy ./coverage-report/coverage-${_split}-raw.info ./coverage-report/coverage-${_split}.info)
+    endif()
+  endforeach()
+
+  add_custom_target(
+    coverage_split
+    COMMAND ${LLVM_PROFDATA} merge -sparse ./coverage-report/profraw/rocsparse-coverage_unit_*.profraw -o ./coverage-report/unit.profdata
+    COMMAND ${LLVM_COV} report ${COVERAGE_OBJECTS} -instr-profile=./coverage-report/unit.profdata
+    COMMAND ${LLVM_COV} export ${COVERAGE_OBJECTS} -instr-profile=./coverage-report/unit.profdata -format=lcov > ./coverage-report/coverage-unit-raw.info
+    ${_split_filter_unit}
+    COMMAND ${LLVM_PROFDATA} merge -sparse ./coverage-report/profraw/rocsparse-coverage_integration_*.profraw -o ./coverage-report/integration.profdata
+    COMMAND ${LLVM_COV} report ${COVERAGE_OBJECTS} -instr-profile=./coverage-report/integration.profdata
+    COMMAND ${LLVM_COV} export ${COVERAGE_OBJECTS} -instr-profile=./coverage-report/integration.profdata -format=lcov > ./coverage-report/coverage-integration-raw.info
+    ${_split_filter_integration}
+    WORKING_DIRECTORY ${CMAKE_BINARY_DIR}
+  )
+
   #
   # Coverage cleanup
   #
   add_custom_target(coverage_cleanup
     COMMAND find ${CMAKE_BINARY_DIR} -name *.gcda -delete
+    COMMAND ${CMAKE_COMMAND} -E rm -rf ./coverage-report/profraw
+    COMMAND ${CMAKE_COMMAND} -E rm -f ./coverage-report/rocsparse.profdata ./coverage-report/unit.profdata ./coverage-report/integration.profdata
     WORKING_DIRECTORY ${CMAKE_BINARY_DIR}
     )
 endif()

projects/rocsparse/clients/tests/testing.md

@@ -395,6 +395,13 @@ do not abort the coverage upload. Both binaries are passed as extra `llvm-cov` `
 attribute coverage to library translation units compiled into the test executables. Jenkins `codecov.groovy` uploads `coverage.info` to Codecov
 with flag `rocSPARSE`.
 
+`make coverage_split` (run after `make coverage`) does not rerun any test. It merges the unit-test
+profiles (`rocsparse-unit-test` and `rocsparse-unit-test-device`) and the `rocsparse-test` profiles
+separately and writes `coverage-report/coverage-unit.info` and
+`coverage-report/coverage-integration.info`. Jenkins uploads them with the Codecov flags
+`rocSPARSE-unit` and `rocSPARSE-integration`, only if `coverage_split` succeeds; the combined
+`rocSPARSE` flag covers both. `make coverage_cleanup` deletes the profiles of a previous run.
+
 **Code coverage vs. test coverage**:
 * *Code coverage* = fraction of lines executed (e.g. 700 of 1,000 → 70%).
 * *Test coverage* = fraction of intended functionality exercised (types, index types, formats, sizes,

projects/rocsparse/clients/unittests/CMakeLists.txt

@@ -73,7 +73,8 @@ add_executable(rocsparse-unit-test
 # ROCSPARSE_EXPORT (and *_NO_EXPORT) to nothing on every platform, which is
 # correct here: these TUs are compiled *into* the test binary, not consumed from
 # the shared library. Test-only; no library change.
-target_compile_definitions(rocsparse-unit-test PRIVATE GOOGLE_TEST ROCSPARSE_STATIC_DEFINE)
+target_compile_definitions(rocsparse-unit-test
+  PRIVATE GOOGLE_TEST ROCSPARSE_STATIC_DEFINE ROCSPARSE_KEEP_INTERNAL_U16)
 target_compile_options(rocsparse-unit-test PRIVATE
   -Wno-deprecated
   -Wno-unused-command-line-argument
@@ -407,6 +408,34 @@ set(ROCSPARSE_UNIT_TEST_DEVICE_LIB_SOURCES
   # (CXX_VISIBILITY_PRESET "hidden"), so the defining TU is compiled into this
   # binary. Build wiring only -- no library source changes.
   ${CMAKE_CURRENT_SOURCE_DIR}/../../library/src/conversion/rocsparse_csr2ell_strided_batched.cpp
+  ${CMAKE_CURRENT_SOURCE_DIR}/../../library/src/conversion/rocsparse_ell2dense.cpp
+  ${CMAKE_CURRENT_SOURCE_DIR}/../../library/src/conversion/rocsparse_coo2dense_aos.cpp
+  ${CMAKE_CURRENT_SOURCE_DIR}/../../library/src/conversion/rocsparse_ggthr.cpp
+  ${CMAKE_CURRENT_SOURCE_DIR}/../../library/src/level1/rocsparse_gthr_impl.cpp
+  ${CMAKE_CURRENT_SOURCE_DIR}/../../library/src/conversion/rocsparse_identity.cpp
+  ${CMAKE_CURRENT_SOURCE_DIR}/../../library/src/conversion/rocsparse_gcreate_identity_permutation.cpp
+  ${CMAKE_CURRENT_SOURCE_DIR}/../../library/src/conversion/rocsparse_csxsldu_compute.cpp
+  ${CMAKE_CURRENT_SOURCE_DIR}/../../library/src/conversion/rocsparse_csr2csc.cpp
+  ${CMAKE_CURRENT_SOURCE_DIR}/../../library/src/conversion/rocsparse_csr2coo.cpp
+  # csritilu0x_*_impl has no public wrapper in the itilu0 API (AISPARSE-921). The symbols
+  # are hidden in librocsparse, so the defining TUs (and the x-driver TUs they
+  # reference) are compiled into this test binary.
+  ${CMAKE_CURRENT_SOURCE_DIR}/../../library/src/precond/itilu0/rocsparse_csritilu0x_compute.cpp
+  ${CMAKE_CURRENT_SOURCE_DIR}/../../library/src/precond/itilu0/rocsparse_csritilu0x_preprocess.cpp
+  ${CMAKE_CURRENT_SOURCE_DIR}/../../library/src/precond/itilu0/rocsparse_csritilu0x_buffer_size.cpp
+  ${CMAKE_CURRENT_SOURCE_DIR}/../../library/src/precond/itilu0/rocsparse_csritilu0x_sync.cpp
+  ${CMAKE_CURRENT_SOURCE_DIR}/../../library/src/precond/itilu0/rocsparse_csritilu0x_async.cpp
+  ${CMAKE_CURRENT_SOURCE_DIR}/../../library/src/precond/itilu0/rocsparse_csritilu0x_sync_fusion.cpp
+  ${CMAKE_CURRENT_SOURCE_DIR}/../../library/src/precond/itilu0/common.cpp
+  # csxsldu buffer-size and preprocess are hidden and the C wrappers are
+  # garbage-collected from librocsparse (AISPARSE-921). Compile the defining TUs so the
+  # column-direction and same-direction branches can run.
+  ${CMAKE_CURRENT_SOURCE_DIR}/../../library/src/conversion/rocsparse_csxsldu_buffer_size.cpp
+  ${CMAKE_CURRENT_SOURCE_DIR}/../../library/src/conversion/rocsparse_csxsldu_preprocess.cpp
+  # rocsparse::internal_spmat_print is declared in a library-internal
+  # header, called by nothing in the library and hidden in librocsparse
+  # (AISPARSE-921).
+  ${CMAKE_CURRENT_SOURCE_DIR}/../../library/src/conversion/rocsparse_internal_spmat_print.cpp
 )
 
 # Internal rocsparse::primitives building blocks under test. Like the host-pure
@@ -428,6 +457,16 @@ set(ROCSPARSE_UNIT_TEST_PRIMITIVE_SOURCES
   ${CMAKE_CURRENT_SOURCE_DIR}/../../library/src/primitives/rocsparse_segmented_radix_sort_pairs.cpp
 )
 
+# Per-area unit-test lists. Each cmake/unit_tests_<area>.cmake appends its
+# sources to ROCSPARSE_UNIT_TEST_DEVICE_SOURCES (or, for host-only translation
+# units, adds them to the already created rocsparse-unit-test target), so an
+# area only adds files and never edits this CMakeLists.txt. A missing area file
+# is skipped (OPTIONAL), so every area can be taken on its own. This must stay
+# after rocsparse-unit-test is created and before rocsparse-unit-test-device is.
+foreach(_unit_test_area level2 conv precond extra host)
+  include(${CMAKE_CURRENT_SOURCE_DIR}/cmake/unit_tests_${_unit_test_area}.cmake OPTIONAL)
+endforeach()
+
 add_executable(rocsparse-unit-test-device
   ${ROCSPARSE_UNIT_TEST_DEVICE_SOURCES}
   ${ROCSPARSE_UNIT_TEST_PRIMITIVE_SOURCES}
@@ -440,7 +479,8 @@ add_executable(rocsparse-unit-test-device
 # (e.g. from library/src/auxiliary/rocsparse_auxiliary.cpp compiled in at the
 # infostructs leaf and beyond). Correct on Linux too (these are definitions
 # built into the executable, not symbols imported from the shared library).
-target_compile_definitions(rocsparse-unit-test-device PRIVATE GOOGLE_TEST ROCSPARSE_STATIC_DEFINE)
+target_compile_definitions(rocsparse-unit-test-device
+  PRIVATE GOOGLE_TEST ROCSPARSE_STATIC_DEFINE ROCSPARSE_KEEP_INTERNAL_U16)
 target_compile_options(rocsparse-unit-test-device PRIVATE
   -Wno-deprecated
   -Wno-unused-command-line-argument
@@ -452,6 +492,8 @@ target_include_directories(rocsparse-unit-test-device PRIVATE
   $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/../../library/src/include>
   $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/../../library/src/level1>
   $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/../../library/src/level3>
+  $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/../../library/src/conversion>
+  $<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/../../library/src/precond/itilu0>
 )
 
 # hip::device provides the HIP device-compilation flags (-x hip, --offload-arch).

projects/rocsparse/clients/unittests/cmake/unit_tests_conv.cmake

@@ -0,0 +1,39 @@
+# ########################################################################
+# Copyright (C) 2026 Advanced Micro Devices, Inc. All rights Reserved.
+#
+# Permission is hereby granted, free of charge, to any person obtaining a copy
+# of this software and associated documentation files (the "Software"), to deal
+# in the Software without restriction, including without limitation the rights
+# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+# copies of the Software, and to permit persons to whom the Software is
+# furnished to do so, subject to the following conditions:
+#
+# The above copyright notice and this permission notice shall be included in
+# all copies or substantial portions of the Software.
+#
+# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+# THE SOFTWARE.
+#
+# ########################################################################
+
+# Unit tests for the conv area (conversion, pruning, sorting, sparse-matrix descriptors).
+# Included from clients/unittests/CMakeLists.txt.
+
+list(APPEND ROCSPARSE_UNIT_TEST_DEVICE_SOURCES
+  unit_test_device_conv_internal.cpp
+  unit_test_device_conv_extract.cpp
+  unit_test_device_conv_sort.cpp
+  unit_test_device_conv_spmat.cpp
+  unit_test_device_conv_prune.cpp
+  unit_test_device_conv_gebsr.cpp
+  unit_test_device_conv_descr.cpp
+  unit_test_device_conv_hyb.cpp
+  unit_test_device_conv_edges.cpp
+  unit_test_device_conv_check.cpp
+  unit_test_device_conv_dense.cpp
+)

projects/rocsparse/clients/unittests/cmake/unit_tests_extra.cmake

@@ -0,0 +1,49 @@
+# ########################################################################
+# Copyright (C) 2026 Advanced Micro Devices, Inc. All rights Reserved.
+#
+# Permission is hereby granted, free of charge, to any person obtaining a copy
+# of this software and associated documentation files (the "Software"), to deal
+# in the Software without restriction, including without limitation the rights
+# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+# copies of the Software, and to permit persons to whom the Software is
+# furnished to do so, subject to the following conditions:
+#
+# The above copyright notice and this permission notice shall be included in
+# all copies or substantial portions of the Software.
+#
+# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+# THE SOFTWARE.
+#
+# ########################################################################
+
+# Unit tests for the extra area (SpMM, SpGEMM, SpGEAM, SDDMM, SpSM, SpTRSM,
+# bsrsm, BELL, gebsrmm, gemmi, spmat_scale).
+# Included from clients/unittests/CMakeLists.txt.
+
+list(APPEND ROCSPARSE_UNIT_TEST_DEVICE_SOURCES
+  unit_test_internal_level3_sddmm_branches.cpp
+  unit_test_device_extra_bell.cpp
+  unit_test_device_extra_bsrgeam.cpp
+  unit_test_device_extra_bsrsm.cpp
+  unit_test_device_extra_csrgemm_bsrgemm.cpp
+  unit_test_device_extra_geam.cpp
+  unit_test_device_extra_gebsrmm.cpp
+  unit_test_device_extra_gemm_geam.cpp
+  unit_test_device_extra_gemmi.cpp
+  unit_test_device_extra_sddmm.cpp
+  unit_test_device_extra_spgeam.cpp
+  unit_test_device_extra_spgemm.cpp
+  unit_test_device_extra_spmm.cpp
+  unit_test_device_extra_spsm.cpp
+)
+if(ROCSPARSE_ENABLE_SPMAT_SCALE)
+  list(APPEND ROCSPARSE_UNIT_TEST_DEVICE_SOURCES unit_test_device_extra_spmat_scale.cpp)
+endif()
+if(BUILD_WITH_TRSM_REFACTORING)
+  list(APPEND ROCSPARSE_UNIT_TEST_DEVICE_SOURCES unit_test_device_extra_sptrsm.cpp)
+endif()

projects/rocsparse/clients/unittests/cmake/unit_tests_host.cmake

@@ -0,0 +1,42 @@
+# ########################################################################
+# Copyright (C) 2026 Advanced Micro Devices, Inc. All rights Reserved.
+#
+# Permission is hereby granted, free of charge, to any person obtaining a copy
+# of this software and associated documentation files (the "Software"), to deal
+# in the Software without restriction, including without limitation the rights
+# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+# copies of the Software, and to permit persons to whom the Software is
+# furnished to do so, subject to the following conditions:
+#
+# The above copyright notice and this permission notice shall be included in
+# all copies or substantial portions of the Software.
+#
+# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+# THE SOFTWARE.
+#
+# ########################################################################
+
+# Unit tests for the host area (bfloat16, BLAS wrappers, auxiliary and
+# library-internal host branches).
+# Included from clients/unittests/CMakeLists.txt.
+
+# rocsparse_bfloat16.h only defines the full rocsparse_bfloat16 struct when
+# compiled as HIP. Build this TU as HIP host code only: no device code object,
+# so the binary stays GPU-independent.
+target_sources(rocsparse-unit-test PRIVATE
+  ${CMAKE_CURRENT_SOURCE_DIR}/unit_test_bfloat16.cpp
+)
+set_source_files_properties(${CMAKE_CURRENT_SOURCE_DIR}/unit_test_bfloat16.cpp PROPERTIES
+  COMPILE_OPTIONS "-x;hip;--offload-host-only"
+)
+
+list(APPEND ROCSPARSE_UNIT_TEST_DEVICE_SOURCES
+  unit_test_internal_common_blas.cpp
+  unit_test_host_auxiliary_branches.cpp
+  unit_test_host_internal_branches.cpp
+)