Skip to content

test(miopen)[ALMIOPEN-2867]: add find/optimizer/misc gtest families to test_categories.yaml (1/9) #13403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aalabsi-amd wants to merge 1 commit into from
Closed

test(miopen)[ALMIOPEN-2867]: add find/optimizer/misc gtest families to test_categories.yaml (1/9) #13403

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions projects/miopen/test/gtest/test_categories.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,10 +64,26 @@ positive_patterns: &positive_patterns
- "*/GPU_Dropout*"
- "*/GPU_MIOpenDriver*"
- "*/GPU_HipGraphExist*"
# Jenkins-parity: Smoke/ and unprefixed cases also run in standard; Full/ cases run in comprehensive/full only.
# Chunk: find/allocator/misc suites, Adam/AmpAdam, pure unprefixed suites.

@JonathanLichtnerAMD JonathanLichtnerAMD Oct 19, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment seems to imply that all the Full/* tests that were just added only run in comprehensive/full, but that is only true for a subset of these. Are these primarily Smoke/* tests? If so, we could add that explicitly here (or add one generic Smoke/* line, maybe immediately before Standard/*, below)

Maybe moving to Smoke/, Standard/, Full/* could help clean this up, so I am okay if you want to defer this

@JonathanLichtnerAMD JonathanLichtnerAMD Oct 19, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more note: you mention testing on standard, comprehensive and full in the TestPlan. Can we make this a checkbox list and also add doing sweeps on other architectures, such as gfx90a, navi, etc, or we might get surprised by nightly failures. The rock tests some architectures that our Jenkins CI didn't cover, and we have different timeout constraints for the rock's GHA vs Jenkins. Thanks!

- "*/GPU_Allocator_*"
- "*/GPU_CandidateSelection_*"
- "*/GPU_Find2Conv_*"
- "*/GPU_FindDb_*"
- "*/GPU_FindModeTrustVerify_*"
- "*/GPU_Adam_*"
- "*/GPU_AmpAdam_*"
# Unprefixed: these are plain TEST/TEST_F with no INSTANTIATE_TEST_SUITE_P,
# so they carry no "Prefix/" and the leading "*/" above would not match them.
- "GPU_StreamTracker_FP32*"
- "GPU_NaiveTimeout_FP32*"
# Jenkins-parity (find/allocator/misc suites, Adam/AmpAdam, pure unprefixed suites): single-instantiation TEST/TEST_F suites.
- "GPU_BN_Spatial_FP32*"
- "GPU_CKValidatorIntegration_FP32*"
- "GPU_CkImplLoader_FP16*"
- "GPU_ConvNDKernelTuningUtils_FP32*"
- "GPU_ConvStridedTensors_FP32*"
- "GPU_SoftmaxFind20_*"
- "Standard/*" # include all standard tests by default


Expand Down Expand Up @@ -169,6 +185,11 @@ test_categories:
- "Full/GPU_BNFWDTrainLargeFusedActivation2D_*"
- "Full/GPU_BNOCLBWDLargeFusedActivation2D_*"
- "Full/GPU_BNOCLInferLargeFusedActivation2D_*"
# Jenkins-parity (find/allocator/misc suites, Adam/AmpAdam, pure unprefixed suites): Smoke/unprefixed cases run here; the Full/ cross product
# runs in comprehensive/full only.
- "Full/GPU_Adam_*"
- "Full/GPU_AmpAdam_*"
- "Full/GPU_CandidateSelection_*"

test_files:
# Quick tests
Expand Down
Loading