Skip to content

chore(hipfft): restore sync-ed contents - #13369

Merged
regan-amd merged 1 commit into
developfrom
users/regan-amd/sync_shared
Oct 9, 2026
Merged

regan-amd merged 1 commit into
developfrom
users/regan-amd/sync_shared

Conversation

@regan-amd

@regan-amd regan-amd commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Motivation

Self-explanatory title, drift introduced in #12054

JIRA ID: AIFFT-532

Technical Details

Self-explanatory title

Test Plan

Usual suite

Test Result

Tests should pass.

Submission Checklist

@regan-amd
regan-amd requested a review from a team as a code owner October 8, 2026 23:33
@therock-pr-bot

therock-pr-bot Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

✅ All Checks Passed — Ready for Review

Check Status Details
📝 PR Description ✅ Pass —
⛔ Forbidden Files ✅ Pass —
🧪 Unit Test ✅ Pass —
🔎 pre-commit ✅ Pass —
🚫 Draft PR 🔜 To Be Enabled —
🚩 Feature Flag 🔜 To Be Enabled —
📊 Code Coverage 🔜 To Be Enabled —
🤖 therock-pr-bot ✅ Pass —

🎉 All checks passed! This PR is ready for review.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@therock-pr-bot

therock-pr-bot Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

🎉 All checks passed! This PR is ready for review.

@codecov

codecov Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
projects/hipfft/shared/device_properties.h 0.00% 9 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #13369      +/-   ##
===========================================
- Coverage    72.16%   72.16%   -0.00%     
===========================================
  Files         2874     2874              
  Lines       474873   474869       -4     
  Branches     70141    70139       -2     
===========================================
- Hits        342674   342648      -26     
- Misses      108398   108411      +13     
- Partials     23801    23810       +9     
Flag Coverage Δ *Carryforward flag
TensileLite-CPP 49.33% <ø> (ø) Carriedforward from 3feaa3f
TensileLite-Unit 83.33% <ø> (ø) Carriedforward from 3feaa3f
hipBLAS 90.62% <ø> (ø) Carriedforward from 3feaa3f
hipBLASLt 41.97% <ø> (ø) Carriedforward from 3feaa3f
hipCUB 82.68% <ø> (ø) Carriedforward from 3feaa3f
hipDNN 86.66% <ø> (ø) Carriedforward from 3feaa3f
hipFFT 42.13% <0.00%> (-0.39%) ⬇️
hipRAND 76.12% <ø> (ø) Carriedforward from 3feaa3f
hipSOLVER 68.96% <ø> (ø) Carriedforward from 3feaa3f
hipSPARSE 86.99% <ø> (ø) Carriedforward from 3feaa3f
rocBLAS 48.17% <ø> (ø) Carriedforward from 3feaa3f
rocFFT 51.44% <ø> (-0.01%) ⬇️ Carriedforward from 3feaa3f
rocRAND 57.45% <ø> (ø) Carriedforward from 3feaa3f
rocSOLVER 76.83% <ø> (ø) Carriedforward from 3feaa3f
rocSPARSE 74.07% <ø> (ø) Carriedforward from 3feaa3f
rocThrust 93.15% <ø> (ø) Carriedforward from 3feaa3f

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
projects/hipfft/shared/device_properties.h 0.00% <0.00%> (ø)

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@regan-amd
regan-amd enabled auto-merge (squash) October 9, 2026 05:24
@regan-amd
regan-amd merged commit 65c39d1 into develop Oct 9, 2026
181 of 197 checks passed
@regan-amd
regan-amd deleted the users/regan-amd/sync_shared branch October 9, 2026 14:34
@assistant-librarian

Copy link
Copy Markdown
Contributor

TheRock Submodule Bump Activity

Newest first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants