Repository navigation
perf(hipblaslt): update gfx942 GridBased BSS NT liblogic file by reassigning solution indices - #13368
Merged
Merged
Conversation
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #13368 +/- ##
===========================================
- Coverage 72.16% 72.16% -0.00%
===========================================
Files 2874 2874
Lines 474873 474873
Branches 70141 70141
===========================================
- Hits 342674 342673 -1
Misses 108398 108398
- Partials 23801 23802 +1
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
Contributor
TheRock Submodule Bump ActivityNewest first
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA ID: https://amd-hub.atlassian.net/browse/AIROCBLAS-1267
Motivation
As part of working on performance parity effort for rocblas-bench with hipBLASLt backend for BF16, the change in this PR reduces the number of regressed cases for BSS ant NT operation type by applying
--algo_method alloptimization.Technical Details
After running
--algo-method allfor the grid-points that are in regressed cases, we reassign the best GridBased solution index for each grid-point. This results in reduces the performance regressed cases w.r.t. Tensile and hipBLASLt backend comparison.Test Result
BSS, NT Case: Baseline vs. Opt
BSS datatype — Total tests: 3,162
Regression Analysis
Backend Timing (seconds)
Overall Improvement with Opt
Submission Checklist