Repository navigation
fix(hipblaslt): omit reserved wave32 directive on gfx125x - #13365
Merged
Merged
Conversation
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
newling
commented
Oct 8, 2026
KKyang
approved these changes
Oct 8, 2026
newling
enabled auto-merge (squash)
October 8, 2026 23:46
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #13365 +/- ##
========================================
Coverage 71.89% 71.89%
========================================
Files 2876 2876
Lines 475549 475549
Branches 70268 70268
========================================
+ Hits 341879 341887 +8
+ Misses 109892 109888 -4
+ Partials 23778 23774 -4
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
newling
force-pushed
the
users/newling/AIHPBLAS-5123-wave32-descriptor
branch
from
October 9, 2026 17:16
e11acf2 to
1fe40e9
Compare
newling
force-pushed
the
users/newling/AIHPBLAS-5123-wave32-descriptor
branch
from
October 10, 2026 00:10
1fe40e9 to
caccb28
Compare
Contributor
TheRock Submodule Bump ActivityNewest first
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA ID : AIHPBLAS-5123
https://amd-hub.atlassian.net/browse/AIHPBLAS-5123
My understanding is that LLVM commit b452df1 makes hipBLASLt's gfx125x kernels fail to assemble. It adds a check that correctly rejects a directive we're emitting. This is holding up a downstream ROCm compiler update: picking up the LLVM change would break the hipBLASLt build in rocm-libraries testing. This PR aims to get those builds passing so that update can go ahead.
gfx125x always execute threads in groups of 32 (wave32). The fix in this PR removes the directive that explicitly requests that group size, and makes sure the kernel generators and assembly readers still treat these kernels as wave32 when the directive is missing.
Focused Python tests pass, StinkyTofu assembly tests also pass. Local checks confirm that the assembly still preserves wave32.
An agent has also tested with the updated compiler before and after this change, and reproduced a failure before and success after.