Skip to content

feat(hipblaslt): tune MAF/MAB for gfx1250 192cu and 96cu - #13362

Merged
minsukim-amd merged 1 commit into
developfrom
users/minsukim/gfx1250_96cu_192cu_maf_mab_update_20261008
Oct 9, 2026
Merged

minsukim-amd merged 1 commit into
developfrom
users/minsukim/gfx1250_96cu_192cu_maf_mab_update_20261008

Conversation

@minsukim-amd

@minsukim-amd minsukim-amd commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

JIRA ID : AIHPBLAS-4949

Motivation

Improve MAF and MAB performance for gfx1250_192cu and gfx1250_96cu

Technical Details

Update MAF and MAB kernels for gfx1250_192cu and gfx1250_96cu

Test Plan

Run hipblaslt-bench for verification and hipblaslt-test

Test Result

Passed both

Submission Checklist

@minsukim-amd
minsukim-amd requested a review from a team as a code owner October 8, 2026 21:20
@therock-pr-bot

therock-pr-bot Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

✅ All Checks Passed — Ready for Review

Check Status Details
📝 PR Description ✅ Pass —
⛔ Forbidden Files ✅ Pass —
🧪 Unit Test ✅ Pass PR does not contain code files — Unit Test auto-passed
🔎 pre-commit ✅ Pass —
🚫 Draft PR 🔜 To Be Enabled —
🚩 Feature Flag 🔜 To Be Enabled —
📊 Code Coverage 🔜 To Be Enabled —
🤖 therock-pr-bot ✅ Pass —

🎉 All checks passed! This PR is ready for review.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@therock-pr-bot

therock-pr-bot Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

🎉 All checks passed! This PR is ready for review.

@codecov

codecov Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

❌ Your project status has failed because the head coverage (41.97%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #13362      +/-   ##
===========================================
+ Coverage    70.82%   70.95%   +0.12%     
===========================================
  Files         2944     2951       +7     
  Lines       484898   487076    +2178     
  Branches     69964    70426     +462     
===========================================
+ Hits        343413   345559    +2146     
+ Misses      117612   117465     -147     
- Partials     23873    24052     +179     
Flag Coverage Δ *Carryforward flag
TensileLite-CPP 49.00% <ø> (ø) Carriedforward from 0aa3fdf
TensileLite-Unit 83.26% <ø> (ø) Carriedforward from 0aa3fdf
hipBLAS 90.62% <ø> (ø) Carriedforward from 0aa3fdf
hipBLASLt 41.97% <ø> (+6.00%) ⬆️
hipCUB 82.68% <ø> (ø) Carriedforward from 0aa3fdf
hipDNN 86.64% <ø> (ø) Carriedforward from 0aa3fdf
hipFFT 54.32% <ø> (ø) Carriedforward from 0aa3fdf
hipRAND 76.12% <ø> (ø) Carriedforward from 0aa3fdf
hipSOLVER 68.96% <ø> (ø) Carriedforward from 0aa3fdf
hipSPARSE 86.99% <ø> (ø) Carriedforward from 0aa3fdf
rocBLAS 48.25% <ø> (ø) Carriedforward from 0aa3fdf
rocFFT 47.11% <ø> (ø) Carriedforward from 0aa3fdf
rocRAND 57.42% <ø> (ø) Carriedforward from 0aa3fdf
rocSOLVER 76.83% <ø> (ø) Carriedforward from 0aa3fdf
rocSPARSE 74.75% <ø> (ø) Carriedforward from 0aa3fdf
rocThrust 78.45% <ø> (ø) Carriedforward from 0aa3fdf

*This pull request uses carry forward flags. Click here to find out more.
see 31 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@minsukim-amd
minsukim-amd merged commit 930b794 into develop Oct 9, 2026
218 of 239 checks passed
@minsukim-amd
minsukim-amd deleted the users/minsukim/gfx1250_96cu_192cu_maf_mab_update_20261008 branch October 9, 2026 03:47
@assistant-librarian

Copy link
Copy Markdown
Contributor

TheRock Submodule Bump Activity

Newest first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants