Repository navigation
test(hipblaslt): write tuning cache test files to the temp directory - #13354
Merged
jinchen62 merged 1 commit intoOct 9, 2026
Merged
Conversation
The TuningCache_pre_checkin tests wrote each tuning file into the current directory and never checked the write. The nightly job runs the installed hipblaslt-test from /opt/rocm-10.2.0/bin, which the test user cannot write, so no file was created. The seven cases that expect the recorded solution got the default one and failed, and the seven that expect the file to be ignored passed without reading a file. The files now go under ::testing::TempDir(), as tuning_store_test.cpp's already do, and every case fails with the file's path when the file cannot be opened or written. Co-authored-by: Cursor <cursoragent@cursor.com>
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
newling
approved these changes
Oct 8, 2026
jinchen62
enabled auto-merge (squash)
October 9, 2026 01:49
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (41.96%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #13354 +/- ##
===========================================
- Coverage 72.16% 72.16% -0.00%
===========================================
Files 2874 2874
Lines 474873 474873
Branches 70141 70141
===========================================
- Hits 342674 342673 -1
Misses 108398 108398
- Partials 23801 23802 +1
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
Contributor
TheRock Submodule Bump ActivityNewest first
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA ID : ROCM-32394
Motivation
hipBLASLt multiplies matrices on AMD GPUs. A tuning file can tell it which kernel, or GPU function, to run for a given problem. The
TuningCache_pre_checkintests, added in #12585, write such a file and check which kernel the library picks. They wrote the file into the current directory and never checked that the write worked.The 10.2.0-20261007 nightly validation runs the installed
hipblaslt-testfrom/opt/rocm-10.2.0/bin, which the test user cannot write, so no file was created. The seven tests that expect the recorded kernel got the default one and failed on all six reported systems. The seven tests that expect the file to be ignored passed without a file to ignore. The 10.2.0-20261006 nightly passed because it was built from a rocm-libraries commit that predates #12585.Technical Details
tempTuningPathnow putshipblaslt_<test name>_<process id>.tuningin GoogleTest's temporary directory,::testing::TempDir(), astuning_store_test.cppalready does. On Linux that is normally/tmp/.writeRawTuningFileandwriteTuningFilereturn a GoogleTest assertion result. The result is a failure that names the path when the file cannot be opened, or when writing or closing it fails.ASSERT_TRUE, so a failed write stops the test at the write instead of at a later check on the selected kernel.clients/tests/src/tuning_cache_test.cppchanges. The library is unchanged.Not addressed here:
tuning_tune_test.cpp, added by #12588, also names its tuning files relative to the current directory and needs the same change.Test Plan
On one AMD Instinct MI355X (gfx950), build
hipblaslt-testfromdevelop(faea76a5cde) with and without this change. Run--gtest_filter='TuningCache_pre_checkin.*'from/tmpand from/opt/rocm/bin, which the test user cannot write. To check the new error message, make the write fail by placing a non-empty directory at the tuning file's path.Test Result
/tmp/opt/rocm/bindevelopThe seven failures on
developare the same cases, at the same lines, as the nightly report. When the write is forced to fail,NamedEntryReplaysandUnnamedEntryFromAnotherBuildIsIgnorednow fail at the write withcould not open tuning file <path>. Ondevelop, the second test passes when no file is written.The automated checks run these tests from a writable directory, which is why they passed on #12585. They cannot reproduce the nightly failure, and they are pending for this change.
Submission Checklist
Risk level
Low (1/5): test-only change. The library and the kernel it selects for applications are unchanged. The tests now need a writable temporary directory instead of a writable current directory.