Repository navigation
feat(stinkytofu): Reduce cluster barrier for long unrolled loops. - #13303
Merged
Merged
Conversation
KKyang
approved these changes
Oct 8, 2026
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
KKyang
approved these changes
Oct 8, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project check has failed because the head coverage (48.93%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #13303 +/- ##
========================================
Coverage 75.95% 75.95%
========================================
Files 2880 2880
Lines 479004 479050 +46
Branches 71955 71965 +10
========================================
+ Hits 363816 363852 +36
- Misses 90329 90340 +11
+ Partials 24859 24858 -1
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
hcman2
force-pushed
the
users/hcman2/one_cluster_br_only
branch
4 times, most recently
from
October 19, 2026 01:37
12f3bb0 to
46456e0
Compare
Contributor
Author
|
[----------] Global test environment tear-down |
hcman2
force-pushed
the
users/hcman2/one_cluster_br_only
branch
from
October 19, 2026 05:47
46456e0 to
3ad3863
Compare
Contributor
Author
|
tox passed on b0 machine w/o sk cases |
hcman2
force-pushed
the
users/hcman2/one_cluster_br_only
branch
from
October 21, 2026 08:11
3ad3863 to
e0d1eb1
Compare
cycheng
approved these changes
Oct 22, 2026
hcman2
force-pushed
the
users/hcman2/one_cluster_br_only
branch
from
October 22, 2026 10:18
c3f450f to
751c770
Compare
Contributor
TheRock Submodule Bump ActivityNewest first
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
JIRA ID: https://amd-hub.atlassian.net/browse/AIHPBLAS-4915
Reduce cluster barrier for multiple unrolled loop.
Technical Details
LoopBeginshare that handshake. A different loop head (tail loop, another path, or a wave-split clone) still gets its own.ReduceClusterBarrierPerLoopmodule option and scheduling knob.<0leaves it unset,0handshakes every loop trigger, and>0uses the reduced cadence. An explicit value wins. A missing or degenerate main loop stays off.sumWmmaLatencyCycles > 2500andsumWmmaLatencyCycles / dsLoadCount >= 5. Division is integer division.StinkyTofuDebugPass: "InsertClusterBarrierPass"prints each reduce-mode decision.StinkyTofuDebugPass: "SchedulingKnobHeuristics"prints the resolved knob and its source (user,policy, orstatic).Test Plan
check perforamance.
Test Result
Submission Checklist