Skip to content

Update codeowners for hipccl - #13260

Merged
stanleytsang-amd merged 1 commit into
developfrom
users/stanleytsang-amd/hipccl-codeowners
Oct 7, 2026
Merged

stanleytsang-amd merged 1 commit into
developfrom
users/stanleytsang-amd/hipccl-codeowners

Conversation

@stanleytsang-amd

Copy link
Copy Markdown
Contributor

Motivation

hipCCL was recently added to rocm-libraries but we didn't update the CODEOWNERS for it yet.

Technical Details

Add hipccl entries to CODEOWNERS.

Test Plan

Test Result

Submission Checklist

@stanleytsang-amd
stanleytsang-amd requested a review from a team as a code owner October 7, 2026 17:08
@github-actions github-actions Bot added the project: none Does not target any component label Oct 7, 2026
@therock-pr-bot

therock-pr-bot Bot commented Oct 7, 2026

Copy link
Copy Markdown

❌ PR Check — Action Required

Check Status Details
📝 PR Description ❌ Fail Error: PR description must reference a JIRA ID, ISSUE ID, or a GitHub closing keyword.
Expected: include a JIRA ID / ISSUE ID line (separator : or -, or omitted; value may be a JIRA key, a number with/without #, or a link), OR a closing keyword + issue reference. Accepted examples:
• JIRA ID : TESTAUTO-6039
• JIRA ID - #330
• JIRA ID #330
• JIRA ID (on separate line)
ROCM-25757
• ISSUE ID : TESTUTO-3334
• ISSUE ID #3334
• ISSUE ID - TESTAUTO-3433
• ISSUE ID (on separate line)
AIRUNTIME-2352
• ISSUE ID : https://github.com/<org_name>/<repo_name>/issues/1234
• Closes #10
• Fixes octo-org/octo-repo#100
• Resolves: #123
• #123
• https://github.com/<org_name>/<repo_name>/issues/123
Current: no valid JIRA/ISSUE/closing-keyword reference found
⛔ Forbidden Files ✅ Pass —
🧪 Unit Test ✅ Pass PR does not contain code files — Unit Test auto-passed
🔎 pre-commit ✅ Pass —
🚫 Draft PR 🔜 To Be Enabled —
🚩 Feature Flag 🔜 To Be Enabled —
📊 Code Coverage 🔜 To Be Enabled —

⚠️ 1 policy check(s) failed. Please address the issues above before this PR can be Reviewed.

🚫 Please fix the failed policies

  • ❌ PR Description

The Not ready to Review label was added to this PR. Once all policies pass, the label is removed automatically.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@therock-pr-bot

therock-pr-bot Bot commented Oct 7, 2026

Copy link
Copy Markdown

🚫 Please fix the failed policies before requesting reviews.

The following policy checks failed:

  • ❌ PR Description

The Not ready to Review label has been added to this PR.
Once all policies pass, the label will be removed automatically.

@stanleytsang-amd
stanleytsang-amd merged commit d132864 into develop Oct 7, 2026
45 of 46 checks passed
@stanleytsang-amd
stanleytsang-amd deleted the users/stanleytsang-amd/hipccl-codeowners branch October 7, 2026 17:19
@assistant-librarian

Copy link
Copy Markdown
Contributor

TheRock Submodule Bump Activity

Newest first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Not ready to Review project: none Does not target any component

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants