Repository navigation
fix(tensilelite): fail the benchmark client on GPU errors during timing - #13117
Merged
Merged
Conversation
The event-based timer ignored HIP return codes, so a kernel fault went unnoticed and the client exited 0 with bogus timings. Check them, and stop the run once the device is unusable instead of continuing on a dead context.
⏳ Waiting on Required Checks⏳ Required checks have not all concluded yet. This bot run is exiting without failing so those checks can report independently.
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
⏳ Waiting for required checks to start or finish:
|
github-actions
Bot
added
project: hipblaslt
project: hipsparselt
ci:hipsparselt-fast
labels
AlexBrownAMD
approved these changes
Oct 5, 2026
Codecov Report❌ Patch coverage is
❌ Your project check has failed because the head coverage (49.02%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #13117 +/- ##
========================================
Coverage 72.12% 72.12%
========================================
Files 2861 2861
Lines 472095 472095
Branches 69805 69813 +8
========================================
+ Hits 340452 340453 +1
Misses 107911 107911
+ Partials 23732 23731 -1
*This pull request uses carry forward flags. Click here to find out more.
🚀 New features to boost your workflow:
|
jaopaulolc
added
the
rocm:gemm algos
Contributor
TheRock Submodule Bump ActivityNewest first
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
If a kernel crashed on the GPU during benchmarking, the TensileLite client did not notice. It reported meaningless timings and exited successfully, so Tensile showed the run as passing.
Technical Details
BenchmarkTimer: errors from the HIP event calls used for timing were ignored. They are now checked, so a GPU error fails the solution being timed.main.cpp: after a solution fails, the client checks whether the GPU can still be used. If it can't, the client stops and exits with a nonzero code instead of running the remaining solutions, which would all fail or crash. Other failures (for example, running out of memory) still continue as before.Test Plan
Ran Tensile with a kernel known to crash on the GPU for one problem size:
Test Result
Submission Checklist
Risk level
Low. This only affects the benchmark client, and only when a GPU error happens. Runs without GPU errors behave the same.
JIRA ID : AIHPBLAS-5062