Repository navigation
fix(rocBLAS) : rot and rot_ex fix ILP64 large N inc handling - #13114
Merged
Merged
Conversation
TorreZuk
added
TestLevel1Only
evedovelli
approved these changes
Oct 7, 2026
evedovelli
left a comment
evedovelli
left a comment
Contributor
There was a problem hiding this comment.
Left a suggestion but the changes look good.
Ryker0627
reviewed
Oct 7, 2026
Ryker0627
reviewed
Oct 7, 2026
Ryker0627
reviewed
Oct 7, 2026
Ryker0627
reviewed
Oct 7, 2026
Ryker0627
approved these changes
Oct 7, 2026
Ryker0627
left a comment
Ryker0627
left a comment
Contributor
There was a problem hiding this comment.
The code fix is good. Just some minor suggestions you may ignore.
TorreZuk
force-pushed
the
users/torrezuk/airocblas-1397-rot-bug
branch
from
October 7, 2026 20:44
a27f752 to
d94b321
Compare
Contributor
Author
|
@Ryker0627 @evedovelli look at last removal commit that is incx,incy 64bit only which is all that we currently have. Optimization can restore the previous branching code pattern if it ever gets done |
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
evedovelli
approved these changes
Oct 8, 2026
assistant-librarian Bot
pushed a commit
to ROCm/rocBLAS
that referenced
this pull request
Oct 8, 2026
fix(rocBLAS) : rot and rot_ex fix ILP64 large N inc handling (#13114) ## Motivation This pull request addresses the handling of negative increments in the 64-bit `rot` kernel launcher, ensuring that offsets are correctly computed when `incx` or `incy` are negative. Additionally, new stress test cases are added to verify this behavior. **Kernel Logic Fixes:** * Updated the computation of `shiftx` and `shifty` in `rocblas_internal_rot_launcher_64` (in `rocblas_rot_kernels_64.cpp`) to correctly handle negative increments by adjusting the offset calculation, ensuring the correct starting point for negative strides. **Testing Improvements:** * Added new stress test cases in `rot_gtest.yaml` with large negative increments for `incx` and `incy`, as well as a case with a large negative `incy`, to validate the correctness of the kernel logic under these scenarios. JIRA ID : AIROCBLAS-1397
Contributor
TheRock Submodule Bump ActivityNewest first
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This pull request addresses the handling of negative increments in the 64-bit
rotkernel launcher, ensuring that offsets are correctly computed whenincxorincyare negative. Additionally, new stress test cases are added to verify this behavior.Kernel Logic Fixes:
shiftxandshiftyinrocblas_internal_rot_launcher_64(inrocblas_rot_kernels_64.cpp) to correctly handle negative increments by adjusting the offset calculation, ensuring the correct starting point for negative strides.Testing Improvements:
rot_gtest.yamlwith large negative increments forincxandincy, as well as a case with a large negativeincy, to validate the correctness of the kernel logic under these scenarios.JIRA ID : AIROCBLAS-1397