[hipBLASLt] Add yaml based testing for host Analytical test#1310
Closed
NaveenElumalaiAMD wants to merge 5 commits into
Closed
[hipBLASLt] Add yaml based testing for host Analytical test#1310NaveenElumalaiAMD wants to merge 5 commits into
NaveenElumalaiAMD wants to merge 5 commits into
Conversation
aliry95amd
approved these changes
Aug 26, 2025
yenong-amd
approved these changes
Aug 27, 2025
neoblizz
approved these changes
Sep 3, 2025
babakpst
approved these changes
Sep 4, 2025
davidd-amd
reviewed
Sep 4, 2025
bstefanuk
reviewed
Sep 4, 2025
bstefanuk
reviewed
Sep 9, 2025
NaveenElumalaiAMD
force-pushed
the
users-nelumala-yaml-test
branch
from
a28e05e to
1ac1fa8
Compare
bstefanuk
approved these changes
Sep 10, 2025
Contributor
bstefanuk
left a comment
bstefanuk
left a comment
There was a problem hiding this comment.
For the CMakeLists.txt changes, looks good.
NaveenElumalaiAMD
force-pushed
the
users-nelumala-yaml-test
branch
from
1ac1fa8 to
e98a09e
Compare
Contributor
Author
|
Rebase was becoming to complicated, so opened a new PR:#1686. Will close this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Instead of hardcoding values to the test, use yaml based inputs to the Analytical tests.
Technical Details
Closing this PR:#1089 in favor for this one. Most of the changes are in the file Analytical_gtest.cpp and Testing_analytical.hpp
Test Plan
yes,
./tensilelite-tests --gtest_filter=*AnalyticalGtest*Test Result
All 17 tests passed