Skip to content

feat(hiptensor): make multiarch the default THEROCK_ASIC in Dockerfile - #13094

Merged
evedovelli merged 1 commit into
developfrom
users/evedovel/hiptensor/multiarch-docker
Oct 8, 2026
Merged

evedovelli merged 1 commit into
developfrom
users/evedovel/hiptensor/multiarch-docker

Conversation

@evedovelli

@evedovelli evedovelli commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Motivation

Set the default THEROCK_ASIC in Dockerfile as multiarch which is functional for any target.

Also, applied clang-format hiptensor.cpp.

ISSUE ID : AIHIPTENS-571

Submission Checklist

@evedovelli evedovelli self-assigned this Oct 5, 2026
@evedovelli
evedovelli requested a review from a team as a code owner October 5, 2026 16:11
@therock-pr-bot

therock-pr-bot Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

⏳ Waiting on Required Checks

⏳ Required checks have not all concluded yet. This bot run is exiting without failing so those checks can report independently.

Check Status Details
📝 PR Description ✅ Pass —
⛔ Forbidden Files ✅ Pass —
🧪 Unit Test ⚠️ Warning Error: Source/code files changed without an accompanying unit test.
Expected: add at least one test file named like test_<name>.py / test_<name>.cpp (or <name>_test.*).
Current: code file(s) changed: projects/hiptensor/library/src/hiptensor.cpp; no test file found
🔎 pre-commit ⏳ Pending ⏳ Still running…
🚫 Draft PR 🔜 To Be Enabled —
🚩 Feature Flag 🔜 To Be Enabled —
📊 Code Coverage 🔜 To Be Enabled —

⏳ Required checks are still running or have not started yet.
This PR is not ready for review until they complete.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@therock-pr-bot

therock-pr-bot Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

⏳ Waiting for required checks to start or finish:

  • ⏳ pre-commit

@Ryker0627 Ryker0627 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@evedovelli
evedovelli merged commit e854e2e into develop Oct 8, 2026
176 of 187 checks passed
@evedovelli
evedovelli deleted the users/evedovel/hiptensor/multiarch-docker branch October 8, 2026 17:41
assistant-librarian Bot pushed a commit to ROCm/hipTensor that referenced this pull request Oct 8, 2026
feat(hiptensor): make multiarch the default THEROCK_ASIC in
 Dockerfile (#13094)

## Motivation

Set the default THEROCK_ASIC in Dockerfile as multiarch which is
functional for any target.

Also, applied clang-format hiptensor.cpp.

ISSUE ID : AIHIPTENS-571

## Submission Checklist

- [x] Look over the contributing guidelines at
https://github.com/ROCm/TheRock/blob/main/GOVERNANCE.md#pull-requests.
@assistant-librarian

Copy link
Copy Markdown
Contributor

TheRock Submodule Bump Activity

Newest first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants