Repository navigation
fix(rocsparse): fix smoke and extended tests - #12985
Merged
Merged
Conversation
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #12985 +/- ##
===========================================
- Coverage 71.93% 71.00% -0.92%
===========================================
Files 2863 2944 +81
Lines 472710 485987 +13277
Branches 69829 70094 +265
===========================================
+ Hits 340010 345068 +5058
- Misses 109117 116981 +7864
- Partials 23583 23938 +355
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
ntrost57
approved these changes
Oct 5, 2026
amontoison
approved these changes
Oct 5, 2026
kliegeois
approved these changes
Oct 7, 2026
assistant-librarian Bot
pushed a commit
to ROCm/rocSPARSE
that referenced
this pull request
Oct 8, 2026
fix(rocsparse): fix smoke and extended tests ## Motivation Before the PR ROCm/rocm-libraries#10500 we were running tests that were not valid but instead of failing were just silently skipped. For example, `prune_dense2csr` is only supported for `float` and `double` but if we ran using `single_double_precisions_complex_real` in the `test_prune_dense2csr.yaml`, the complex precision tests would be silently skipped. What the PR ROCm/rocm-libraries#10500 does is fix that so that the test fails with a message instead of silently failing. This allows developers to see when they are adding invalid tests and remove them. What the PR ROCm/rocm-libraries#10500 forgot to do was to check the `rocsparse_smoke.yaml`, `rocsparse_regression.yaml`, and `rocsparse_extended.yaml` tests to make sure that they had any invalid tests removed. The is now causing errors when running: `GTEST_LISTENER=VERBOSE_PASS_IN_LOG ./rocsparse-test --yaml rocsparse_smoke.yaml` or `GTEST_LISTENER=VERBOSE_PASS_IN_LOG ./rocsparse-test --yaml rocsparse_extended.yaml --matrices-dir ../matrices` This PR fixes these errors by removing the invalid tests from `rocsparse_smoke.yaml` and `rocsparse_extended.yaml`. JIRA ID: ROCM-32122
Contributor
TheRock Submodule Bump ActivityNewest first
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Before the PR #10500 we were running tests that were not valid but instead of failing were just silently skipped. For example,
prune_dense2csris only supported forfloatanddoublebut if we ran usingsingle_double_precisions_complex_realin thetest_prune_dense2csr.yaml, the complex precision tests would be silently skipped. What the PR #10500 does is fix that so that the test fails with a message instead of silently failing. This allows developers to see when they are adding invalid tests and remove them.What the PR #10500 forgot to do was to check the
rocsparse_smoke.yaml,rocsparse_regression.yaml, androcsparse_extended.yamltests to make sure that they had any invalid tests removed. The is now causing errors when running:GTEST_LISTENER=VERBOSE_PASS_IN_LOG ./rocsparse-test --yaml rocsparse_smoke.yamlor
GTEST_LISTENER=VERBOSE_PASS_IN_LOG ./rocsparse-test --yaml rocsparse_extended.yaml --matrices-dir ../matricesThis PR fixes these errors by removing the invalid tests from
rocsparse_smoke.yamlandrocsparse_extended.yaml.JIRA ID: ROCM-32122