Repository navigation
fix(tensilelite): generate aux output E in persistent kernels #12869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jaopaulolc
merged 9 commits into
develop
from
users/jolabega/fix-tensilelite-streamk-aux-codegen
Oct 7, 2026
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
74e2139
fix(tensilelite): generate aux output E in persistent kernels
jaopaulolc 5bff6e3
Merge branch 'develop' into users/jolabega/fix-tensilelite-streamk-au…
jaopaulolc e49d700
test(tensilelite): cover Stream-K parallel reduction with aux output E
jaopaulolc 878ab6b
Merge branch 'develop' into users/jolabega/fix-tensilelite-streamk-au…
jaopaulolc 23cb111
Merge branch 'develop' into users/jolabega/fix-tensilelite-streamk-au…
jaopaulolc 7cdcaab
Merge branch 'develop' into users/jolabega/fix-tensilelite-streamk-au…
jaopaulolc 88df9d7
Merge branch 'develop' into users/jolabega/fix-tensilelite-streamk-au…
jaopaulolc df06c92
Merge branch 'develop' into users/jolabega/fix-tensilelite-streamk-au…
jaopaulolc 75e73e5
Merge branch 'develop' into users/jolabega/fix-tensilelite-streamk-au…
jaopaulolc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
109 changes: 109 additions & 0 deletions
109
...slt/tensilelite/Tensile/Tests/common/streamk/gfx950/data_parallel_static_hgemm_use_e.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,109 @@ | ||
| # Copyright Advanced Micro Devices, Inc., or its affiliates. | ||
| # SPDX-License-Identifier: MIT | ||
|
|
||
| TestParameters: | ||
| marks: [skip-gfx900, skip-gfx906, skip-gfx908, skip-gfx90a, skip-gfx940, skip-gfx941, skip-gfx942, skip-gfx1010, skip-gfx1011, skip-gfx1012, skip-gfx1030, skip-gfx1100, skip-gfx1101, skip-gfx1102, skip-gfx1200, skip-gfx1201, skip-gfx1250, skip-gfx1250-strict] | ||
|
|
||
| GlobalParameters: | ||
| Architecture: gfx950 | ||
| NumElementsToValidate: -1 | ||
| BoundsCheck: 0 | ||
| KernelTime: False | ||
| NumWarmups: 0 | ||
| NumBenchmarks: 1 | ||
| SyncsPerBenchmark: 0 | ||
| EnqueuesPerSync: 1 | ||
| DataInitTypeAlpha: 1 | ||
| DataInitTypeBeta: 1 | ||
| DataInitTypeA: 12 | ||
| DataInitTypeB: 13 | ||
| DataInitTypeC: 12 | ||
| DataInitTypeE: 21 | ||
| MaxWorkspaceSize: 134217728 | ||
| PrintSolutionRejectionReason: True | ||
|
|
||
| BenchmarkProblems: | ||
| # Bias + activation, pre-activation values written to E | ||
| - | ||
| - OperationType: GEMM | ||
| DataType: h | ||
| DestDataType: h | ||
| ComputeDataType: s | ||
| HighPrecisionAccumulate: True | ||
| TransposeA: False | ||
| TransposeB: False | ||
| UseBeta: True | ||
| Batched: True | ||
| UseBias: 1 | ||
| Activation: True | ||
| ActivationType: hipblaslt_all | ||
| UseE: True | ||
| DataTypeE: h | ||
| - InitialSolutionParameters: | ||
| BenchmarkCommonParameters: | ||
| - KernelLanguage: [Assembly] | ||
| ForkParameters: | ||
| - MatrixInstruction: | ||
| - [16, 16, 16, 1, 1, 4, 4, 2, 2] | ||
| - DepthU: [64] | ||
| - 1LDSBuffer: [1] | ||
| - GlobalReadVectorWidthA: [8] | ||
| - GlobalReadVectorWidthB: [8] | ||
| - PrefetchGlobalRead: [2] | ||
| - PrefetchLocalRead: [1] | ||
| - ScheduleIterAlg: [3] | ||
| - SourceSwap: [False, True] | ||
| - TileProcessingStrategy: [DataParallel] | ||
| - WorkAssignment: [StaticGrid] | ||
| - ActivationFuncCall: [False, True] | ||
| BenchmarkJoinParameters: | ||
| BenchmarkFinalParameters: | ||
| - ProblemSizes: | ||
| - Exact: [512, 512, 1, 512] | ||
| - Exact: [129, 97, 1, 1030] | ||
| - Exact: [1031, 1031, 1, 4103] | ||
| - BiasTypeArgs: ['s'] | ||
| - ActivationArgs: | ||
| - [Enum: Relu] | ||
| - [Enum: Gelu] | ||
|
|
||
| # Gradient: E is read back for the activation derivative | ||
| - | ||
| - OperationType: GEMM | ||
| DataType: h | ||
| DestDataType: h | ||
| ComputeDataType: s | ||
| HighPrecisionAccumulate: True | ||
| TransposeA: False | ||
| TransposeB: False | ||
| UseBeta: True | ||
| Batched: True | ||
| UseBias: 0 | ||
| Activation: True | ||
| ActivationType: hipblaslt_all | ||
| Gradient: True | ||
| UseE: True | ||
| DataTypeE: h | ||
| - InitialSolutionParameters: | ||
| BenchmarkCommonParameters: | ||
| - KernelLanguage: [Assembly] | ||
| ForkParameters: | ||
| - MatrixInstruction: | ||
| - [16, 16, 16, 1, 1, 4, 4, 2, 2] | ||
| - DepthU: [64] | ||
| - 1LDSBuffer: [1] | ||
| - GlobalReadVectorWidthA: [8] | ||
| - GlobalReadVectorWidthB: [8] | ||
| - PrefetchGlobalRead: [2] | ||
| - PrefetchLocalRead: [1] | ||
| - ScheduleIterAlg: [3] | ||
| - SourceSwap: [False, True] | ||
| - TileProcessingStrategy: [DataParallel] | ||
| - WorkAssignment: [StaticGrid] | ||
| BenchmarkJoinParameters: | ||
| BenchmarkFinalParameters: | ||
| - ProblemSizes: | ||
| - Exact: [512, 512, 1, 512] | ||
| - Exact: [1031, 1031, 1, 4103] | ||
| - ActivationArgs: | ||
| - [Enum: Dgelu] |
113 changes: 113 additions & 0 deletions
113
projects/hipblaslt/tensilelite/Tensile/Tests/common/streamk/gfx950/sk_hgemm_use_e.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,113 @@ | ||
| # Copyright Advanced Micro Devices, Inc., or its affiliates. | ||
| # SPDX-License-Identifier: MIT | ||
|
|
||
| TestParameters: | ||
| marks: [skip-gfx900, skip-gfx906, skip-gfx908, skip-gfx90a, skip-gfx940, skip-gfx941, skip-gfx942, skip-gfx1010, skip-gfx1011, skip-gfx1012, skip-gfx1030, skip-gfx1100, skip-gfx1101, skip-gfx1102, skip-gfx1200, skip-gfx1201, skip-gfx1250, skip-gfx1250-strict] | ||
|
|
||
| GlobalParameters: | ||
| Architecture: gfx950 | ||
| NumElementsToValidate: -1 | ||
| BoundsCheck: 0 | ||
| KernelTime: False | ||
| NumWarmups: 0 | ||
| NumBenchmarks: 1 | ||
| SyncsPerBenchmark: 0 | ||
| EnqueuesPerSync: 1 | ||
| DataInitTypeAlpha: 1 | ||
| DataInitTypeBeta: 1 | ||
| DataInitTypeA: 12 | ||
| DataInitTypeB: 13 | ||
| DataInitTypeC: 12 | ||
| DataInitTypeE: 21 | ||
| MaxWorkspaceSize: 134217728 | ||
| PrintSolutionRejectionReason: True | ||
|
|
||
| BenchmarkProblems: | ||
| # Bias + activation, pre-activation values written to E | ||
| - | ||
| - OperationType: GEMM | ||
| DataType: h | ||
| DestDataType: h | ||
| ComputeDataType: s | ||
| HighPrecisionAccumulate: True | ||
| TransposeA: False | ||
| TransposeB: False | ||
| UseBeta: True | ||
| Batched: True | ||
| UseBias: 1 | ||
| Activation: True | ||
| ActivationType: hipblaslt_all | ||
| UseE: True | ||
| DataTypeE: h | ||
| - InitialSolutionParameters: | ||
| BenchmarkCommonParameters: | ||
| - KernelLanguage: [Assembly] | ||
| ForkParameters: | ||
| - MatrixInstruction: | ||
| - [16, 16, 16, 1, 1, 4, 4, 2, 2] | ||
| - DepthU: [64] | ||
| - 1LDSBuffer: [1] | ||
| - GlobalReadVectorWidthA: [8] | ||
| - GlobalReadVectorWidthB: [8] | ||
| - PrefetchGlobalRead: [2] | ||
| - PrefetchLocalRead: [1] | ||
| - ScheduleIterAlg: [3] | ||
| - SourceSwap: [False, True] | ||
| - TileProcessingStrategy: [StreamK] | ||
| - WorkAssignment: [StaticGrid, DynamicWorkQueue, Hybrid] | ||
| - StreamKFixupTreeReduction: [0, 1] | ||
| - ActivationFuncCall: [False, True] | ||
| BenchmarkJoinParameters: | ||
| BenchmarkFinalParameters: | ||
| - ProblemSizes: | ||
| - Exact: [512, 512, 1, 512] | ||
| - Exact: [129, 97, 1, 1030] | ||
| - Exact: [1031, 1031, 1, 4103] | ||
| # Few tiles and a long K: parallel reduction with the post kernel | ||
| - Exact: [512, 512, 1, 8192] | ||
| - BiasTypeArgs: ['s'] | ||
| - ActivationArgs: | ||
| - [Enum: Relu] | ||
| - [Enum: Gelu] | ||
|
|
||
| # Gradient: E is read back for the activation derivative | ||
| - | ||
| - OperationType: GEMM | ||
| DataType: h | ||
| DestDataType: h | ||
| ComputeDataType: s | ||
| HighPrecisionAccumulate: True | ||
| TransposeA: False | ||
| TransposeB: False | ||
| UseBeta: True | ||
| Batched: True | ||
| UseBias: 0 | ||
| Activation: True | ||
| ActivationType: hipblaslt_all | ||
| Gradient: True | ||
| UseE: True | ||
| DataTypeE: h | ||
| - InitialSolutionParameters: | ||
| BenchmarkCommonParameters: | ||
| - KernelLanguage: [Assembly] | ||
| ForkParameters: | ||
| - MatrixInstruction: | ||
| - [16, 16, 16, 1, 1, 4, 4, 2, 2] | ||
| - DepthU: [64] | ||
| - 1LDSBuffer: [1] | ||
| - GlobalReadVectorWidthA: [8] | ||
| - GlobalReadVectorWidthB: [8] | ||
| - PrefetchGlobalRead: [2] | ||
| - PrefetchLocalRead: [1] | ||
| - ScheduleIterAlg: [3] | ||
| - SourceSwap: [False, True] | ||
| - TileProcessingStrategy: [StreamK] | ||
| - WorkAssignment: [StaticGrid] | ||
| BenchmarkJoinParameters: | ||
| BenchmarkFinalParameters: | ||
| - ProblemSizes: | ||
| - Exact: [512, 512, 1, 512] | ||
| - Exact: [1031, 1031, 1, 4103] | ||
| - Exact: [512, 512, 1, 8192] | ||
| - ActivationArgs: | ||
| - [Enum: Dgelu] |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.