Repository navigation
Conversation
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rocm-libraries’ Multi-Arch CI reuses prebuilt HIP tests from a TheRock baseline while rebuilding the HIP runtime from the pinned TheRock revision. The current baseline predates that revision, so CI combines an updated runtime with older test binaries and metadata. This causes unrelated PRs, including #12720, to fail the required Multi-Arch gate.
Two upstream changes explain the failures. rocm-systems #12250 enabled same-device device-to-device batch copies and updated the tests accordingly. The reused
Unit_hipMemcpyBatchAsync_Swapbinary still expectshipErrorNotSupported, while the rebuilt runtime returns success. Separately, rocm-systems #12148 disabled HRR capture and its smoke tests by default. The reused test metadata still enablesUnit_HRR_CaptureSmoke, which fails because the runtime no longer creates the expected capture directory. In both cases, the runtime and test changes landed together upstream; our artifact reuse combines versions from before and after those changes.This updates the prebuilt baseline from run
36226176568to run36388943167, built at the existing TheRock pin,7440cb8578f4. It preserves runtime-test reuse and avoids adding test-build stages to every PR. The accompanying comment identifies this as a temporary alignment: manually keeping the pin and baseline synchronized is not sustainable, and artifact reuse needs automated compatibility checks.The selected baseline passes all Linux and Windows PAL HIP-test shards. Its separate Windows ROCR stream-wait hangs remain unresolved by this change.
Validation: confirmed that the baseline revision matches the pin, the reused-stage builds succeeded, and all artifacts copied by the affected workflow are available. Pre-commit and actionlint passed. The baseline change still needs a fresh rocm-libraries CI run.