Repository navigation
Pass ENVIRONMENT_MODIFICATION to hip-kernel-provider test registration - #12804
Merged
CMiservaAMD merged 1 commit intoOct 7, 2026
Conversation
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
CMiservaAMD
marked this pull request as ready for review
October 1, 2026 13:59
CMiservaAMD
enabled auto-merge (squash)
October 1, 2026 22:57
…stration hip-kernel-provider was the only provider under dnn-providers/ whose test registration omitted ENVIRONMENT_MODIFICATION. Its peers (miopen-provider, integration-tests) forward TEST_ENVIRONMENT_MODIFICATION alongside TEST_ENVIRONMENT, which on Windows ASAN builds is what prepends the clang runtime directory holding clang_rt.asan_dynamic-x86_64.dll -- plus the build bin and ROCm bin directories -- onto the test's PATH. Without it the generated suites started with an unmodified PATH and could not resolve the ASAN runtime DLL. hip_kernel_provider_tests_standard_suite, hip_kernel_provider_integration_tests_standard_suite, hip-kernel-provider-external-integration_standard_suite and hip-kernel-provider-asm-sdpa-external-integration_standard_suite all exited with 0xc0000135 (STATUS_DLL_NOT_FOUND) in under 0.05 s, never reaching main(). TEST_ENVIRONMENT_MODIFICATION is set by dnn-providers/cmake/Sanitizers.cmake, included at the provider root before add_subdirectory(src), so it is in scope at every touched call site. It is empty on non-ASAN and non-Windows builds, where each helper skips the property entirely. The gfx950 attention-dense and gpu_ref external-integration targets carry the same omission and are fixed alongside; they are not registered by every configuration but fail identically where they are. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
CMiservaAMD
force-pushed
the
users/cmiserva/almiopen-2821/fix-hip-kernel-provider-windows-asan-test-env
branch
from
October 6, 2026 17:31
a13df63 to
3e16f3e
Compare
CMiservaAMD
deleted the
users/cmiserva/almiopen-2821/fix-hip-kernel-provider-windows-asan-test-env
branch
October 7, 2026 10:52
adickin-amd
added a commit
that referenced
this pull request
Oct 7, 2026
Conflicts: - HIP_MLOPS_ENGINE_test_categories_integration.yaml: keep the cascaded comprehensive tier (no full_*), which makes develop's full_Layernorm* carve-out (#13180) unnecessary. - hip-kernel-provider/src/integration_tests/CMakeLists.txt: keep the all-tier GTEST_FILTER and take develop's ENVIRONMENT_MODIFICATION (#12804).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hip-kernel-provider registered its CTest suites without passing ENVIRONMENT_MODIFICATION, unlike the three peer providers under dnn-providers/. In a Windows AddressSanitizer build this left the test executables unable to resolve the ASAN runtime DLL, and four suites exited 0xc0000135 (STATUS_DLL_NOT_FOUND) in under 0.05 s without reaching main. This passes the keyword at the hip-kernel-provider registration sites so they match the peers.
JIRA ID : ALMIOPEN-2821
Risk Assessment
Risk 2. TEST_ENVIRONMENT_MODIFICATION is set only when BUILD_ADDRESS_SANITIZER is enabled on Windows, and the registration helpers emit nothing when the variable is empty, so the change is a no-op in every non-ASAN and non-Windows configuration. No kernel selection, dispatch, default, or support-surface behaviour changes.
ASIC Coverage
Architecture-independent: the change alters the test process environment only. Standard PR CI is the appropriate bar and no multi-arch sweep is warranted on the merits.
Caveat a reviewer should know: no CI lane covers the affected configuration. The ASAN multi-arch workflows accept only linux_amdgpu_families, and therock-ci-windows.yml does not enable ASAN, so PR CI can confirm this is a no-op elsewhere but cannot verify the fix itself. Verification is local, on Windows / gfx1103.
Also note that four of the seven changed call sites (the gfx950, asm-sdpa and kernel-ingestor targets) are gated off in the verifying configuration and so were not exercised. They carry the identical omission and the identical fix.
Testing Summary
Testing Checklist
python -m unittest test_parse_test_categories -k environment_modification- Status: Passedcmake -E env CMAKE_BUILD_PARALLEL_LEVEL=4 cmake --build build/release-gfx1103-asan-newstd -j 4- Status: Passedctest -L standard- Status: In progressTechnical Changes
🤖 Generated with Claude Code