Repository navigation
Conversation
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
Abuudiii
force-pushed
the
users/Abdullah/rocfft-internal-test-planning
branch
from
September 29, 2026 16:16
bb69c6c to
5281658
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project check has failed because the head coverage (49.14%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #12663 +/- ##
===========================================
+ Coverage 70.61% 70.63% +0.02%
===========================================
Files 2939 2939
Lines 483991 487452 +3461
Branches 69779 71169 +1390
===========================================
+ Hits 341740 344267 +2527
- Misses 118379 119290 +911
- Partials 23872 23895 +23
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
malcolmroberts
requested changes
Oct 23, 2026
malcolmroberts
left a comment
malcolmroberts
left a comment
Contributor
There was a problem hiding this comment.
Jira ticket is closed, but this isn't merged - can you clarify this please?
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Split from #11272. The planning core had no unit tests and was not compiled into the internal test binary.
Technical Details
plan_test.cpp- decomposition, scheme choice, Bluestein selection, transpose fusion, buffer assignmentrepo_test.cpp- twiddle and chirp tables are reused, not rebuilttests/CMakeLists.txtbuilds the planning sources intorocfft-internal-testand linkship::device.powX.cppstays out because it carries device code, sorocfft_stub.cppsupplies its three functions behindROCFFT_BUILD_INTERNAL_TEST. The shipping library is unchanged.Test Plan
Built this branch alone on develop and ran every
rocfft-internal-testcase in its own process on MI210 (gfx90a), ROCm 7.1.0.Test Result
16/16 new tests pass, 20/20 total.
The other test PRs split from #11272 each add one line to
tests/CMakeLists.txt; merging this one first keeps their rebases trivial.Submission Checklist