Skip to content

fix(tensilelite): repair LLVM YAML shared test linking - #12655

Closed
ThanHenderson wants to merge 1 commit into
developfrom
users/nhenders/fix-yaml-test-link
Closed

ThanHenderson wants to merge 1 commit into
developfrom
users/nhenders/fix-yaml-test-link

Conversation

@ThanHenderson

@ThanHenderson ThanHenderson commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

JIRA ID : N/A

Motivation

The TensileLite C++ test executable fails to link when LLVM YAML serialization and shared libraries are enabled.

Technical Details

  • Give the YAML-enabled test target its direct LLVM headers and LLVMObjectYAML dependency. The prediction-library tests call LLVM YAML functions themselves.
  • Make the master-library YAML mapping a partial template specialization. Its implementation is instantiated when used, so including the header for prediction serialization no longer pulls in every library subtype and references private runtime symbols.
  • Remove the unused YAML adapter include from RangeLibrary_test.cpp, which loads files through LoadLibraryFile.

Test Plan

Build tensilelite-tests with TENSILELITE_BUILD_TESTING=ON, TENSILELITE_BUILD_SHARED_LIBS=ON, and HIPBLASLT_ENABLE_YAML=ON. Run the prediction, range, selection, caching, and custom-kernel host tests. Check full-library loading through LoadLibraryFile. Repeat the build and relevant tests with HIPBLASLT_ENABLE_YAML=OFF for MessagePack.

Test Result

  • Unmodified develop at 7affebf2fef fails to link. Both complete test executables build with this patch.
  • LLVM YAML: 23 selected tests passed, including all four prediction-deserialization cases.
  • MessagePack: 78 selected tests passed, including the library mapping, compressed-loading, and indexed-loading cases.
  • Both runs retained the existing RangeLibrary skip for AIHPBLAS-3506; MessagePack also retained its disabled timing benchmark.
  • A standalone LoadLibraryFile smoke check loaded all nine solutions and their selection tree from a YAML conversion of KernelsLite.dat, omitting its obsolete CustomKernelName field.

These YAML checks ran locally; the standard CI configuration uses MessagePack.

@therock-pr-bot

therock-pr-bot Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

❌ PR Check — Action Required

Check Status Details
📝 PR Description ❌ Fail Error: PR description must reference a JIRA ID, ISSUE ID, or a GitHub closing keyword.
Expected: include a JIRA ID / ISSUE ID line (separator : or -, or omitted; value may be a JIRA key, a number with/without #, or a link), OR a closing keyword + issue reference. Accepted examples:
• JIRA ID : TESTAUTO-6039
• JIRA ID - #330
• JIRA ID #330
• JIRA ID (on separate line)
ROCM-25757
• ISSUE ID : TESTUTO-3334
• ISSUE ID #3334
• ISSUE ID - TESTAUTO-3433
• ISSUE ID (on separate line)
AIRUNTIME-2352
• ISSUE ID : https://github.com/<org_name>/<repo_name>/issues/1234
• Closes #10
• Fixes octo-org/octo-repo#100
• Resolves: #123
• #123
• https://github.com/<org_name>/<repo_name>/issues/123
Current: no valid JIRA/ISSUE/closing-keyword reference found
⛔ Forbidden Files ✅ Pass —
🧪 Unit Test ✅ Pass —
🔎 pre-commit ✅ Pass —
🚫 Draft PR 🔜 To Be Enabled —
🚩 Feature Flag 🔜 To Be Enabled —
📊 Code Coverage 🔜 To Be Enabled —

⚠️ 1 policy check(s) failed. Please address the issues above before this PR can be Reviewed.

🚫 Please fix the failed policies

  • ❌ PR Description

The Not ready to Review label was added to this PR. Once all policies pass, the label is removed automatically.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@therock-pr-bot

therock-pr-bot Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

🚫 Please fix the failed policies before requesting reviews.

The following policy checks failed:

  • ❌ PR Description

The Not ready to Review label has been added to this PR.
Once all policies pass, the label will be removed automatically.

@codecov

codecov Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

❌ Your project check has failed because the head coverage (48.82%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #12655   +/-   ##
========================================
  Coverage    70.43%   70.43%           
========================================
  Files         2932     2932           
  Lines       482413   482414    +1     
  Branches     69547    69547           
========================================
+ Hits        339767   339768    +1     
  Misses      118785   118785           
  Partials     23861    23861           
Flag Coverage Δ *Carryforward flag
TensileLite-CPP 48.82% <ø> (ø)
TensileLite-Unit 81.59% <ø> (+<0.01%) ⬆️
hipBLAS 90.62% <ø> (ø) Carriedforward from 7affebf
hipBLASLt 35.55% <ø> (ø) Carriedforward from 7affebf
hipCUB 82.68% <ø> (ø) Carriedforward from 7affebf
hipDNN 86.70% <ø> (ø) Carriedforward from 7affebf
hipFFT 54.32% <ø> (ø) Carriedforward from 7affebf
hipRAND 76.12% <ø> (ø) Carriedforward from 7affebf
hipSOLVER 68.96% <ø> (ø) Carriedforward from 7affebf
hipSPARSE 86.99% <ø> (ø) Carriedforward from 7affebf
rocBLAS 48.25% <ø> (ø) Carriedforward from 7affebf
rocFFT 46.67% <ø> (ø) Carriedforward from 7affebf
rocRAND 57.42% <ø> (ø) Carriedforward from 7affebf
rocSOLVER 76.83% <ø> (ø) Carriedforward from 7affebf
rocSPARSE 74.76% <ø> (ø) Carriedforward from 7affebf
rocThrust 78.34% <ø> (ø) Carriedforward from 7affebf

*This pull request uses carry forward flags. Click here to find out more.
see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

Copy link
Copy Markdown
Contributor

This pull request has been inactive for 25 days and will be marked as stale.

If you would like to keep this PR open, please:

  • Add new commits
  • Add a comment explaining why it should remain open

This PR will be automatically closed in 5 days if no further activity occurs.

@github-actions github-actions Bot added the Stale PR has no activity for 25+ days label Oct 25, 2026
@github-actions

Copy link
Copy Markdown
Contributor

This pull request has been automatically closed due to inactivity (30 days with no updates).

If you'd like to continue working on this, feel free to reopen the PR or create a new one.

@github-actions github-actions Bot closed this Oct 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant