Repository navigation
fix(tensilelite): repair LLVM YAML shared test linking - #12655
ThanHenderson wants to merge 1 commit into
Conversation
❌ PR Check — Action Required
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🚫 Please fix the failed policies before requesting reviews. The following policy checks failed:
The |
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project check has failed because the head coverage (48.82%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #12655 +/- ##
========================================
Coverage 70.43% 70.43%
========================================
Files 2932 2932
Lines 482413 482414 +1
Branches 69547 69547
========================================
+ Hits 339767 339768 +1
Misses 118785 118785
Partials 23861 23861
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
|
This pull request has been inactive for 25 days and will be marked as stale. If you would like to keep this PR open, please:
This PR will be automatically closed in 5 days if no further activity occurs. |
|
This pull request has been automatically closed due to inactivity (30 days with no updates). If you'd like to continue working on this, feel free to reopen the PR or create a new one. |
JIRA ID : N/A
Motivation
The TensileLite C++ test executable fails to link when LLVM YAML serialization and shared libraries are enabled.
Technical Details
LLVMObjectYAMLdependency. The prediction-library tests call LLVM YAML functions themselves.RangeLibrary_test.cpp, which loads files throughLoadLibraryFile.Test Plan
Build
tensilelite-testswithTENSILELITE_BUILD_TESTING=ON,TENSILELITE_BUILD_SHARED_LIBS=ON, andHIPBLASLT_ENABLE_YAML=ON. Run the prediction, range, selection, caching, and custom-kernel host tests. Check full-library loading throughLoadLibraryFile. Repeat the build and relevant tests withHIPBLASLT_ENABLE_YAML=OFFfor MessagePack.Test Result
developat7affebf2feffails to link. Both complete test executables build with this patch.LoadLibraryFilesmoke check loaded all nine solutions and their selection tree from a YAML conversion ofKernelsLite.dat, omitting its obsoleteCustomKernelNamefield.These YAML checks ran locally; the standard CI configuration uses MessagePack.