Repository navigation
fix(miopen): resolve uint64_t typedef conflict with system headers on LP64 Linux #12623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
schung-amd
merged 6 commits into
develop
from
users/schung-amd/fix-miopen-cstdint-lp64-typedef-conflict
Sep 29, 2026
Merged
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
d1d115f
fix(miopen): resolve uint64_t typedef conflict with system headers on…
schung-amd 0191de5
Merge branch 'develop' into users/schung-amd/fix-miopen-cstdint-lp64-…
schung-amd 54ac416
fix(miopen): use MIOpen gtest naming convention for test suite
schung-amd 01b8cc4
fix(miopen): address review — use __UINT64_TYPE__, SPDX header, JIT test
schung-amd 194b56f
fix(miopen): include <stdint.h> in JIT test to reproduce original con…
schung-amd 23270dc
fix(miopen): match repo SPDX license convention
schung-amd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,68 @@ | ||
| /******************************************************************************* | ||
| * | ||
| * MIT License | ||
| * | ||
| * Copyright (c) 2026 Advanced Micro Devices, Inc. | ||
| * | ||
| * Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| * of this software and associated documentation files (the "Software"), to deal | ||
| * in the Software without restriction, including without limitation the rights | ||
| * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| * copies of the Software, and to permit persons to whom the Software is | ||
| * furnished to do so, subject to the following conditions: | ||
| * | ||
| * The above copyright notice and this permission notice shall be included in all | ||
| * copies or substantial portions of the Software. | ||
| * | ||
| * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE | ||
| * SOFTWARE. | ||
| * | ||
| *******************************************************************************/ | ||
|
schung-amd marked this conversation as resolved.
Resolved
|
||
|
|
||
| // Regression test for TheRock#6258 / LP64 typedef conflict in miopen_cstdint.hpp. | ||
| // | ||
| // On LP64 platforms (64-bit Linux, macOS), <stdint.h> defines uint64_t as | ||
| // 'unsigned long', but __hip_internal::uint64_t is 'unsigned long long'. | ||
| // These are distinct C++ types despite being the same width, so a typedef | ||
| // redefinition is a hard error when both are visible. | ||
|
|
||
| #include <gtest/gtest.h> | ||
| #include <cstdint> | ||
| #include <type_traits> | ||
|
|
||
| #define MIOPEN_HIP_RUNTIME_COMPILE | ||
| #define HIP_PACKAGE_VERSION_FLAT 7015026333ULL | ||
|
|
||
| // Provide __hip_internal types as they would appear during HIPRTC compilation | ||
| namespace __hip_internal { | ||
| typedef unsigned long long uint64_t; | ||
| typedef signed long long int64_t; | ||
| } // namespace __hip_internal | ||
|
|
||
| // Include the header under test — this must not conflict with <cstdint> above | ||
| #include "miopen_cstdint.hpp" | ||
|
|
||
| #undef MIOPEN_HIP_RUNTIME_COMPILE | ||
|
|
||
| TEST(CPU_MiopenCstdintLP64_NONE, Uint64TypeMatchesSystem) | ||
|
averinevg marked this conversation as resolved.
Resolved
|
||
| { | ||
| EXPECT_TRUE((std::is_same<::uint64_t, std::uint64_t>::value)) | ||
| << "miopen_cstdint.hpp uint64_t must be the same type as <cstdint> uint64_t"; | ||
| } | ||
|
|
||
| TEST(CPU_MiopenCstdintLP64_NONE, Int64TypeMatchesSystem) | ||
| { | ||
| EXPECT_TRUE((std::is_same<::int64_t, std::int64_t>::value)) | ||
| << "miopen_cstdint.hpp int64_t must be the same type as <cstdint> int64_t"; | ||
| } | ||
|
|
||
| TEST(CPU_MiopenCstdintLP64_NONE, SizesAre64Bit) | ||
| { | ||
| EXPECT_EQ(sizeof(::uint64_t), 8u); | ||
| EXPECT_EQ(sizeof(::int64_t), 8u); | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.