Repository navigation
feat(rocblas): add the generated Fortran binding in bindings/fortran/rocblas - #12533
Draft
amontoison wants to merge 8 commits into
Draft
amontoison wants to merge 8 commits into
amontoison wants to merge 8 commits into
Conversation
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project check has failed because the head coverage (69.20%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #12533 +/- ##
===========================================
+ Coverage 75.95% 76.00% +0.05%
===========================================
Files 2880 2880
Lines 479025 479393 +368
Branches 71958 72033 +75
===========================================
+ Hits 363828 364336 +508
+ Misses 90338 90163 -175
- Partials 24859 24894 +35
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
amontoison
force-pushed
the
users/amontoison/rocblas-fortran-bindings
branch
4 times, most recently
from
September 25, 2026 04:17
9a0e9f2 to
b07f8d7
Compare
This was referenced Sep 25, 2026
amontoison
force-pushed
the
users/amontoison/rocblas-fortran-bindings
branch
2 times, most recently
from
September 28, 2026 03:48
f3d55bd to
8c1e0cf
Compare
amontoison
force-pushed
the
users/amontoison/rocblas-fortran-bindings
branch
3 times, most recently
from
October 3, 2026 16:50
46b5663 to
535bc58
Compare
amontoison
changed the title
amontoison
force-pushed
the
users/amontoison/rocblas-fortran-bindings
branch
from
October 5, 2026 05:12
535bc58 to
175abbf
Compare
Add fortran/rocblas.F90, the rocblas module generated from the C headers by the rocm-fortran generator under RFC0019 (ROCm/TheRock#8122). It is committed next to the headers, is not edited by hand, and .gitattributes marks it linguist-generated.
amontoison
force-pushed
the
users/amontoison/rocblas-fortran-bindings
branch
from
October 22, 2026 13:22
175abbf to
dc40b1d
Compare
…ted one
Build fortran/rocblas.F90 as roc::rocblas_fortran from fortran/, a CMake
project of its own that the root adds. BUILD_FORTRAN_BINDINGS (default
${UNIX}) and FORTRAN_ARRAY_INTERFACES (default assumed-shape) control
it; the existing BUILD_FORTRAN_CLIENTS is forced OFF when no binding is
built. ROCBLAS_BUILD_FORTRAN_* override both per library. The .mod and
the archive install per compiler under <includedir>/fortran/<compiler>
and <libdir>/fortran/<compiler>, beside a rocblas-fortran config
package.
Remove library/include/rocblas_module.f90. Its rocblas_enums module is
folded into rocblas, so use rocblas_enums becomes use rocblas, and
rocblas_create_handle and rocblas_get_stream take their output by
reference. The clients shims and samples use the generated module, and
the trmm sample is fixed and built; there is no fortran/test suite.
Refs: ROCm/TheRock#8122 (RFC0019)
amontoison
force-pushed
the
users/amontoison/rocblas-fortran-bindings
branch
from
October 22, 2026 18:13
dc40b1d to
c2b7a02
Compare
The rocBLAS Fortran binding consumes rocBLAS's public API and builds standalone against an installed rocBLAS, so it moves out of the library into bindings/fortran/rocblas, the tree every monorepo and TheRock use for the Fortran bindings (RFC0015). Nothing is wired into the library build any more: the library is back to its state on develop. Its hand-written Fortran module stays for now: its deprecation and removal, with the Fortran clients that use it, follow in separate pull requests. - bindings/fortran/rocblas reads rocBLAS's version from projects/rocblas - the binding has its own .gitattributes and CHANGELOG.md - CODEOWNERS: /bindings/fortran/rocblas/, same owners - repos-config.json: register bindings/fortran/rocblas so CI detects changes
github-actions
Bot
added
github actions
project: none
amontoison
changed the title
…tests - regenerate bindings/fortran/rocblas with rocm-fortran-generator 9c8b3e4 - commit its metadata in bindings/fortran/rocblas/metadata/, where the generator reads it from a checkout - add the binding's tests in test/, under BUILD_FORTRAN_CLIENTS, ported from hipFORT's rocBLAS tests: the library's own clients still test the hand-written module while it is deprecated, so they did not test the binding
Install the test executables in bin/, and a CTestTestfile.cmake in bin/rocblas-fortran/ with the same tests and properties as the build tree, so that ctest --test-dir runs them from an install, as TheRock's test jobs do for the libraries.
The binding is built against an installed rocBLAS and is never added to the library's build, so drop what only served that: the per-library BUILD_FORTRAN_* overrides, the PARENT_SCOPE results, the ROCM_HAVE_FORTRAN shortcut, the gating on the library's client and test options, and the comments about the root. Find the Fortran compiler through the cmake/ROCmFortranCompiler.cmake shared by all the bindings, and require CMake 3.19.
…-fortran The package files went to lib/cmake/rocblas, the C library's directory, with a forwarder in lib/cmake/rocblas-fortran. rocRAND and hipRAND install their own legacy <lib>-fortran-config.cmake there, so the files overlapped. Install the config, targets and version files directly where find_package(<package>) looks, as the HIP and ROCTx bindings do, and drop the forwarder.
…ut recursion rocm-cmake's generated rocblas-config.cmake is to include lib/cmake/rocblas-fortran/rocblas-fortran-config.cmake after its targets (ROCm/rocm-cmake#303). Skip find_dependency(rocblas) when rocblas is the package being found, not only when roc::rocblas is already imported, so that include never re-enters rocblas-config.cmake.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements RFC0015, Fortran Bindings Split (update) for rocBLAS:
bindings/fortran/rocblas/is a standalone CMake project that builds the generated Fortran binding against an installed rocBLAS. The library is untouched: no option, noadd_subdirectory, no change toprojects/rocblas/.What lands
bindings/fortran/rocblas/rocblas.F90(168 236 lines, generated with ROCm/rocm-fortran-generator 9c8b3e4 from the rocBLAS headers, markedlinguist-generated): one modulerocblaswith thebind(C)interfaces, the enum constants, therocblasCheckhelper and array overloads for the routines the generator supports.metadata/rocblas.toml: the generator metadata it was generated with.test/: 245 CTest tests, 148.f03tests of the C interfaces and 97.f08tests of the array overloads (registered as<name>_f2008). They also install: the executables inbin/, and aCTestTestfile.cmakewith the same tests and properties inbin/rocblas-fortran/, forctest --test-dir.CMakeLists.txt, therocblas-fortranconfig template,cmake/ROCmFortranCompiler.cmake(the same in every binding: ROCm'samdflangis preferred over the first compiler onPATHunlessCMAKE_Fortran_COMPILERorFCis set),cmake/toolchains/and the binding'sCHANGELOG.md..github/CODEOWNERS:/bindings/fortran/rocblas/ @ROCm/rocm-fortran-maintainers @ROCm/rocblas-reviewers..github/repos-config.json: abindings/fortranentry, so CI detects changes to the binding. Each binding PR appends its entry at the end of the list, so all but the first to merge need a trivial rebase.A consumer uses
find_package(rocblas-fortran)and linksroc::rocblas_fortran. The archive and.modfiles install per compiler underlib/fortran/<compiler>/andinclude/fortran/<compiler>/;ROCBLAS_FORTRAN_COMPILER_DIRnames that directory. The archive has one section per procedure, so a program linked with-Wl,--gc-sectionskeeps only the wrappers it calls.Options
BUILD_FORTRAN_BINDINGS${UNIX}BUILD_FORTRAN_CLIENTSONtest/; off underBUILD_ADDRESS_SANITIZERFORTRAN_ARRAY_INTERFACESassumed-shapenone/assumed-shape/assumed-rankarray overloadsIn TheRock
ROCm/TheRock#9446 builds
bindings/fortran/rocblasas therocblas-fortransubproject against the rocBLAS it built, with-DBUILD_FORTRAN_BINDINGS=ON -DBUILD_FORTRAN_CLIENTS=${THEROCK_BUILD_TESTING}, ships it in theblas-fortranartifact and runs the installed tests in itsrocblas-fortranGPU test job.Follow-ups
This binding replaces the hand-written
library/include/rocblas_module.f90, which stays for now. Deprecating it, then removing it and moving the library's Fortran clients to this binding, come in separate pull requests.Build and test
From the repository root, with
$PREFIXthe install prefix:$HIP_FORTRAN_PREFIXholds the HIP Fortran binding (hip-fortran) built with the same compiler; without it the tests are skipped.Verification
Standalone against ROCm 10.1 with amdflang on one GPU: 245 tests, 245 pass. From the install tree,
ctest --test-dir $PREFIX/bin/rocblas-fortrangives the same result.JIRA ID: ROCM-31390