Repository navigation
feat(rocke): disable unroll k for basic pipeline - #12409
Merged
Merged
Conversation
github-actions
Bot
added
project: hip-kernel-provider
rocke: platform
aledudek
force-pushed
the
users/aledudek/rocke-wgrad-group-merge
branch
2 times, most recently
from
September 22, 2026 14:17
b742a9b to
23bb138
Compare
Base automatically changed from
users/aledudek/rocke-wgrad-group-merge
to
develop
September 22, 2026 21:53
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
One or more issues must be addressed before approval.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 3
Open (5)
What changed in this PR
Updates ROCm’s rocKE implicit-GEMM convolution codegen to use runtime K-loops for the basic pipeline, while adding grouped wgrad split-K tuning and depthwise group merging.
Changes:
- Replaces basic-pipeline Python unrolling with bounded runtime loops in Python and C++.
- Adds groups-, block-size-, XCD-, and grid-limit-aware split-K selection.
- Adds group-merge codegen, validation, workspace handling, benchmarks, and tests.
| File | Description |
|---|---|
| dnn-providers/hip-kernel-provider/rocke/platform/tests/instances/rocke_ir_parity_harness.py | Updated as part of this pull request. |
| dnn-providers/hip-kernel-provider/rocke/platform/tests/dispatch/dispatch_tests/gemm/test_split_k_wgrad.py | Updated as part of this pull request. |
| dnn-providers/hip-kernel-provider/rocke/platform/python/rocke/helpers/split_k.py | Updated as part of this pull request. |
| dnn-providers/hip-kernel-provider/rocke/platform/cpp/instances/common/conv_implicit_gemm_wgrad.cpp | Updated as part of this pull request. |
| dnn-providers/hip-kernel-provider/rocke/platform/cpp/instances/common/conv_implicit_gemm_conv_build_glue.cpp | Updated as part of this pull request. |
| dnn-providers/hip-kernel-provider/rocke/library/tests/test_conv_wgrad_correctness.py | Updated as part of this pull request. |
| dnn-providers/hip-kernel-provider/rocke/library/tests/dispatch/test_grouped_conv_wgrad_dispatch.py | Updated as part of this pull request. |
| dnn-providers/hip-kernel-provider/rocke/library/kernels/common/conv_implicit_gemm.py | Updated as part of this pull request. |
| dnn-providers/hip-kernel-provider/rocke/library/kernels/common/conv_implicit_gemm_wgrad.py | Updated as part of this pull request. |
| dnn-providers/hip-kernel-provider/rocke/library/kernels/common/conv_implicit_gemm_wgrad_two_stage.py | Updated as part of this pull request. |
| dnn-providers/hip-kernel-provider/rocke/library/dispatch/grouped_convolution.py | Updated as part of this pull request. |
| dnn-providers/hip-kernel-provider/rocke/library/benchmarks/common/benchmark_implicit_gemm_conv.py | Updated as part of this pull request. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
bartekxk
force-pushed
the
users/barkocot/disable-basic-unroll-k
branch
from
September 23, 2026 12:18
16acaf7 to
8833eff
Compare
bartekxk
force-pushed
the
users/barkocot/disable-basic-unroll-k
branch
from
September 23, 2026 12:44
8833eff to
5c8430b
Compare
aledudek
requested changes
Sep 23, 2026
Contributor
PR #12409 — Reviewed with Claude 4.7🟡 = should change
Verdict: PASS — 0 blocking. Clean refactor, Python↔C++ parity kept, goldens/test/docs updated together. |
aledudek
reviewed
Sep 24, 2026
Contributor
TheRock Submodule Bump ActivityNewest first
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Speedup compilation time
Technical Details
Disable unroll k for basic pipeline in implicit gemm conv.
Test Plan
test_conv_*_corectness.py
Test Result
Passed
Submission Checklist
JIRA ID: AICK-2217