Skip to content

Set execute bit on hipsparselt/install-host.sh - #12371

Merged
talumbau merged 1 commit into
developfrom
tja/tlh-r1-execbit
Sep 23, 2026
Merged

talumbau merged 1 commit into
developfrom
tja/tlh-r1-execbit

Conversation

@talumbau

Copy link
Copy Markdown
Collaborator

projects/hipsparselt/install.sh is mode 100755 in git; install-host.sh is 100644.

Any build driver that does chmod +x install.sh install-host.sh therefore changes the mode of install-host.sh only. That dirties the work tree, and rocm_setup_version runs git describe --dirty --long --match [0-9]* (ROCMSetupVersion.cmake:91, falling back to the same command with --always). Either way --dirty is honoured, so the version becomes <sha>-dirty and CPack renders it as an RPM release of <sha>_dirty.

This is visible in shipped drop artifacts today:

hipblaslt-1.5.0.70002-3045c0f797.el9.x86_64.rpm         <- clean
hipsparselt-0.2.9.70002-3045c0f797_dirty.el9.x86_64.rpm <- dirty

hipBLASLt has no chmod step in its build driver, which is the only reason it stays clean.

The execute bit is not needed for correctness — tasks.py:217 invokes the script as ["bash", str(HOST_SCRIPT), ...], and nothing else in the tree executes it directly. Making the two scripts consistent removes the incentive to chmod at all.

Verified against a clean clone:

clean tree  -> a3adf0a8562
after chmod -> a3adf0a8562-dirty

TheRock impact: none (file mode only).

Companion change in rocJenkins removes the chmod from the drop builder.

install.sh is mode 100755 but install-host.sh is 100644. Build drivers
that chmod +x the pair (for example the rocJenkins hipblaslt-builder
Dockerfile) therefore change the mode of install-host.sh only, which
makes the work tree dirty and lands a spurious "_dirty" suffix in the
hipSPARSELt RPM release field via `git describe --dirty`.

Making the two scripts consistent removes the incentive to chmod at all.

Co-Authored-By: Claude <noreply@anthropic.com>
@therock-pr-bot

Copy link
Copy Markdown

❌ PR Check — Action Required

Check Status Details
📝 PR Description ❌ Fail Error: PR description must reference a JIRA ID, ISSUE ID, or a GitHub closing keyword.
Expected: include a JIRA ID / ISSUE ID line (separator : or -, or omitted; value may be a JIRA key, a number with/without #, or a link), OR a closing keyword + issue reference. Accepted examples:
• JIRA ID : TESTAUTO-6039
• JIRA ID - #330
• JIRA ID #330
• JIRA ID (on separate line)
ROCM-25757
• ISSUE ID : TESTUTO-3334
• ISSUE ID #3334
• ISSUE ID - TESTAUTO-3433
• ISSUE ID (on separate line)
AIRUNTIME-2352
• ISSUE ID : https://github.com/<org_name>/<repo_name>/issues/1234
• Closes #10
• Fixes octo-org/octo-repo#100
• Resolves: #123
• #123
• https://github.com/<org_name>/<repo_name>/issues/123
Current: no valid JIRA/ISSUE/closing-keyword reference found
⛔ Forbidden Files ✅ Pass —
🧪 Unit Test ✅ Pass PR does not contain code files — Unit Test auto-passed
🔎 pre-commit ✅ Pass —
🚫 Draft PR 🔜 To Be Enabled —
🚩 Feature Flag 🔜 To Be Enabled —
📊 Code Coverage 🔜 To Be Enabled —

⚠️ 1 policy check(s) failed. Please address the issues above before this PR can be Reviewed.

🚫 Please fix the failed policies

  • ❌ PR Description

The Not ready to Review label was added to this PR. Once all policies pass, the label is removed automatically.

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@therock-pr-bot

Copy link
Copy Markdown

🚫 Please fix the failed policies before requesting reviews.

The following policy checks failed:

  • ❌ PR Description

The Not ready to Review label has been added to this PR.
Once all policies pass, the label will be removed automatically.

@talumbau
talumbau marked this pull request as ready for review September 21, 2026 21:08
@talumbau
talumbau requested a review from a team as a code owner September 21, 2026 21:08
@talumbau
talumbau enabled auto-merge (squash) September 21, 2026 21:09
@talumbau
talumbau requested a review from hcman2 September 23, 2026 02:07
@talumbau
talumbau merged commit 06451c3 into develop Sep 23, 2026
130 of 134 checks passed
@talumbau
talumbau deleted the tja/tlh-r1-execbit branch September 23, 2026 02:11
@assistant-librarian

Copy link
Copy Markdown
Contributor

TheRock Submodule Bump Activity

Newest first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants