Repository navigation
Set execute bit on hipsparselt/install-host.sh - #12371
Merged
Merged
Conversation
install.sh is mode 100755 but install-host.sh is 100644. Build drivers that chmod +x the pair (for example the rocJenkins hipblaslt-builder Dockerfile) therefore change the mode of install-host.sh only, which makes the work tree dirty and lands a spurious "_dirty" suffix in the hipSPARSELt RPM release field via `git describe --dirty`. Making the two scripts consistent removes the incentive to chmod at all. Co-Authored-By: Claude <noreply@anthropic.com>
❌ PR Check — Action Required
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🚫 Please fix the failed policies before requesting reviews. The following policy checks failed:
The |
talumbau
marked this pull request as ready for review
September 21, 2026 21:08
talumbau
enabled auto-merge (squash)
September 21, 2026 21:09
vin-huang
approved these changes
Sep 23, 2026
Contributor
TheRock Submodule Bump ActivityNewest first
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
projects/hipsparselt/install.shis mode100755in git;install-host.shis100644.Any build driver that does
chmod +x install.sh install-host.shtherefore changes the mode ofinstall-host.shonly. That dirties the work tree, androcm_setup_versionrunsgit describe --dirty --long --match [0-9]*(ROCMSetupVersion.cmake:91, falling back to the same command with--always). Either way--dirtyis honoured, so the version becomes<sha>-dirtyand CPack renders it as an RPM release of<sha>_dirty.This is visible in shipped drop artifacts today:
hipBLASLt has no
chmodstep in its build driver, which is the only reason it stays clean.The execute bit is not needed for correctness —
tasks.py:217invokes the script as["bash", str(HOST_SCRIPT), ...], and nothing else in the tree executes it directly. Making the two scripts consistent removes the incentive tochmodat all.Verified against a clean clone:
TheRock impact: none (file mode only).
Companion change in rocJenkins removes the
chmodfrom the drop builder.