Repository navigation
build(tensilelite): align requirements-test.txt limits with tox.ini and pyproject.toml - #12319
Merged
Conversation
…nd pyproject.toml requirements-test.txt is the fifth place in tensilelite/ that declares Python dependencies, after requirements.txt, requirements-dev.txt, pyproject.toml ([project].dependencies and [dependency-groups].dev), and the inline deps in tox.ini. Today they agree; nothing checks that they keep agreeing. The hard pins are the part that can diverge silently, so relax them to the limits already stated elsewhere: pytest==9.0.3 -> pytest>=5.4.1 (tox.ini:21, pyproject.toml:105) PyYAML==6.0.2 -> PyYAML (requirements.txt) packaging==25.0 -> packaging (requirements.txt, pyproject.toml:77) syrupy==5.3.2 -> syrupy (tox.ini:24, pyproject.toml:108) pytest is the one that matters: 9.x is a major release, and the artifact test lane would have run it while `tox -e unit` resolved pytest>=5.4.1 to something else. Two lanes, two majors, no validation of 9.x against this suite. pytest-timeout==2.4.0 is kept because tox.ini:23 states the same value, and the four >= floors are kept because a floor does not contradict a bare requirement. Also add `-r ./requirements-test.txt` to requirements-dev.txt. That makes the new file part of the set rather than a fifth parallel copy, and it fixes an existing gap: requirements-dev.txt ships no test runner at all, so the geko README setup step (utilities/geko/README.md:268) currently leaves developers without pytest. Co-Authored-By: Claude <noreply@anthropic.com>
1 task done
ScottTodd
approved these changes
Sep 18, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## users/scotttodd/tensilelite-test-requirements #12319 +/- ##
==============================================================================
Coverage 70.60% 70.60%
==============================================================================
Files 2799 2799
Lines 458957 458957
Branches 67480 67480
==============================================================================
Hits 324029 324029
Misses 111633 111633
Partials 23295 23295
*This pull request uses carry forward flags. Click here to find out more. 🚀 New features to boost your workflow:
|
talumbau
merged commit Sep 18, 2026
a96f709
into
users/scotttodd/tensilelite-test-requirements
178 of 194 checks passed
talumbau
deleted the
users/talumbau/tensilelite-test-requirements-consistency
branch
September 18, 2026 20:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA ID : N/A
Targets #11396 rather than
develop— merge into that branch to pick these up.Motivation
#11396 adds
tensilelite/requirements-test.txt. Moving the list out of TheRock and next to the tests is a clear improvement, and the CMake install rule is correct as written (including the absence ofOPTIONAL, which is what makes a bad path fail loudly rather than be skipped).The concern is only the version limits.
requirements-test.txtis the fifth place undertensilelite/that declares Python dependencies:requirements.txtinstall.sh:47,tox.ini:20,124,165,MANIFEST.inrequirements-dev.txtutilities/geko/README.md:268setup steppyproject.toml[project].dependenciesuv.lock, and tox's sdist install (noskipsdist)pyproject.toml[dependency-groups].devuv synctox.ini:16-26inlinedepsThey agree today. Nothing checks that they keep agreeing.
requirements-test.txtis the only one of the five that hard-pins, so it is the one that drifts first — and nothing in CI would report it.Technical Details
Relax the four hard pins to the limits already stated elsewhere in the tree:
pytest==9.0.3>=5.4.1tox.ini:21,pyproject.toml:105PyYAML==6.0.2requirements.txtpackaging==25.0requirements.txt,pyproject.toml:77syrupy==5.3.2tox.ini:24,pyproject.toml:108On
pytestTo be precise about what the problem is and is not: the newest pytest is 9.1.1, and
>=5.4.1is a floor rather than a pin, sotox -e unitalready resolves to pytest 9 today. This is not a case of two lanes running two different majors.The problem is that
==9.0.3freezes one lane while every other lane floats. They start together and separate over time.The
>=5.4.1floor is itself stale — it traces to the pytest 5.3.3 defect note attox.ini:12-14, which is years old. It does need raising. The right place to raise it ispyproject.toml, using PEP 735include-groupnesting so a single declaration propagates, rather than a new version arriving by hand in a fifth file.On the other three
PyYAML,packagingandsyrupyfloat everywhere else in the repo, so the least damaging thing is to let them float here too until this is settled throughpyproject.toml. This is consistency rather than risk:packaginghas exactly one use in the package (Tensile/Common/Parallel.py:38), and PyYAML 6.x is interface-stable.syrupydeserves a footnote. There are 101.ambrsnapshot files underTensile/Tests, so the syrupy version and those files are coupled and a pin has a real purpose. But a pin in one file of three does not help — it makes the artifact lane and the tox lane read the same snapshots with different engines. One value in all three files is the actual fix, and that is larger than this PR.Kept unchanged
pytest-timeout==2.4.0—tox.ini:23already states the same value.msgpack>=1.0.0,joblib>=1.4.0,numpy>=1.26.0,filelock>=3.0.0— a floor does not contradict a bare requirement, so these add information without creating a second source of truth.projects/hipblaslt/CMakeLists.txt— no change.requirements-dev.txtOne line added:
-r ./requirements-test.txt.This links the new file into the set instead of leaving it as a fifth parallel list, and it closes a gap that exists today:
requirements-dev.txtships no test runner at all, so anyone following the geko README setup step (utilities/geko/README.md:268) ends up without pytest.-rpaths resolve against the directory of the file that contains them, so this line is safe from any working directory.requirements-test.txtitself gains no-rline, so it remains standalone for CI and for shipped artifacts, which do not clone the source repo.Note this does not yet remove the overlap between
requirements.txtandrequirements-test.txt— seven packages are still declared in both. See the follow-ups.Test Plan
No behavioural change to any code path. Nothing reads
requirements-test.txtyet — TheRock currently uses its ownbuild_tools/github_actions/test_executable_scripts/requirements-test-tensilelite.txt(ROCm/TheRock#7728) — so this only affects the contents of the installed test artifact.Checks: the existing #11396 CI, which exercises the
install(FILES ...)rule viaHIPBLASLT_INSTALL_TENSILELITE_TEST_ARTIFACTS(ROCm/TheRock:math-libs/BLAS/CMakeLists.txt:172sets it fromTHEROCK_BUILD_TESTING).Test Result
Pending CI on this branch. Worth knowing when reading the green checks: the contents of the file are unvalidated by CI on either branch until TheRock installs from it. The
Test tensilelitejob uses the runner's ambient pytest.Submission Checklist
Risk level
None. Four version limits relaxed to values already declared elsewhere in the tree, plus one
-rline. No code, no build logic, no CMake changes.Follow-ups (not in this PR)
requirements.txtandrequirements-test.txt(seven packages), keepingrequirements-test.txtstandalone../rocisafromrequirements-dev.txt. It is a CWD-relative path (see the workaround comment atutilities/geko/tox.ini:47) and it produces a different install thaninvoke rocisa— noROCM_PATH, noROCISA_INCLUDE_BUILD_INFO=ON, non-editable, with build isolation. Needs a matching geko README update.pyproject.tomlthe single source of truth for versions, with PEP 735 nesting so one declaration propagates, and a check that reports drift. This is what theTODOin the file refers to.🤖 Generated with Claude Code