Skip to content

fix(tensilelite): correct gfx1250 gate residual instruction size #12235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alex391a merged 1 commit into from
Sep 18, 2026
Merged

fix(tensilelite): correct gfx1250 gate residual instruction size #12235

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion projects/hipblaslt/tensilelite/Tensile/KernelWriterAssembly.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15820,7 +15820,7 @@ def globalWriteElements(self, kernel, tPA, tPB, vectorWidths_2, vectorWidths_1,
# s = gate null ? 1.0 : 0.0. FMA does acc = (gate+s)*acc + gate.
# No separate compare needed: allocPostLoopSrdSuppress leaves SCC = (AddressGate == 0)
# module.add(self.getSCMPKInstruction("EQU32", "SrdGate+2", 0, comment="gate null? (SrdGate num_records==0)"))
module.add(SCSelectB32(dst=sgpr("GateNullOne"), src0=hex(0x3f800000), src1=0, comment="GateNullOne = (gate null) ? 1.0 : 0.0"))
module.add(SCSelectB32(dst=sgpr("GateNullOne"), src0=1.0, src1=0, comment="GateNullOne = (gate null) ? 1.0 : 0.0"))
module.add(self.shiftSrd("Gate"))
ssslist.append("Gate")
useSize.append(False)
Expand Down
1 change: 1 addition & 0 deletions projects/hipblaslt/tensilelite/Tensile/Tests/common/sparse/gfx1250/spmm_gate.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
TestParameters:
marks: [skip-gfx900, skip-gfx906, skip-gfx908, skip-gfx90a, skip-gfx940, skip-gfx941, skip-gfx942, skip-gfx950, skip-gfx1010, skip-gfx1011, skip-gfx1012, skip-gfx1030, skip-gfx1100, skip-gfx1101, skip-gfx1102, skip-gfx1200, skip-gfx1201, xfail-gfx1250] # xfail-gfx1250: known failure on gfx1250 HW
GlobalParameters:
CheckASMCodeSize: True
SyncsPerBenchmark: 0
NumElementsToValidate: -1
KernelTime: True
Expand Down
Loading