Repository navigation
[TEST - DO NOT MERGE] Verify TheRock DVC/wkmi fix (ROCm/TheRock#8204) - #12082
Closed
tony-davis wants to merge 2 commits into
Closed
tony-davis wants to merge 2 commits into
tony-davis wants to merge 2 commits into
Conversation
Temporarily pins therock-ref to TheRock PR #8204's branch commit (users/todavis/fix-dvc-rocm-systems-external-libraries) instead of develop, to verify the DVC/wkmi fix resolves the compiler-runtime (Windows) and wsl-rocdxg (Linux) failures seen in #12060/#12067. Not for merge. Co-authored-by: Cursor <cursoragent@cursor.com>
github-actions
Bot
added
github actions
project: none
tony-davis
marked this pull request as ready for review
September 14, 2026 23:28
tony-davis
marked this pull request as draft
September 14, 2026 23:28
✅ All Checks Passed — Ready for Review
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
|
🎉 All checks passed! This PR is ready for review. |
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
It changes multiple CI workflows and shared settings for temporary validation and requires human review.
Pull request overview
This test-only PR temporarily pins ROCm/TheRock CI to PR #8204’s fix for validation and is not intended for merging.
Changes:
- Updates TheRock references across CI, nightly, ASAN, and clang-tidy workflows.
- Disables baseline reuse to force full validation builds.
- Updates shared CI environment settings.
File summaries
| File | Reviewed change |
|---|---|
.github/workflows/therock-multi-arch-ci.yml |
Pins multi-architecture CI. |
.github/workflows/therock-multi-arch-ci-nightly.yml |
Pins nightly multi-architecture CI. |
.github/workflows/therock-multi-arch-ci-asan.yml |
Pins ASAN CI. |
.github/workflows/therock-multi-arch-ci-asan-nightly.yml |
Pins nightly ASAN CI. |
.github/workflows/therock-ci-nightly.yml |
Updates the nightly fallback reference. |
.github/workflows/clang-tidy.yml |
Pins the clang-tidy checkout. |
.github/actions/ci-env/action.yml |
Updates the shared pin and disables baseline reuse. |
Review details
- Files reviewed: 7/7 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Author
|
Test complete. Worked. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Manual, temporary pin of
therock-refto the branch backingROCm/TheRock#8204 (fix for
ROCm/TheRock#8203), to verify it resolves
the
compiler-runtime(Windows) andwsl-rocdxg(Linux) failures seen in #12060 and #12067.This is not an automated submodule bump and should not be merged. Closing once CI results
confirm (or refute) the fix.
Made with Cursor