Skip to content

fix(rocsparse): Removing non-sense stream creation I introduced. - #12079

Merged
YvanMokwinski merged 1 commit into
ROCm:developfrom
YvanMokwinski:handle-stream
Sep 16, 2026
Merged

YvanMokwinski merged 1 commit into
ROCm:developfrom
YvanMokwinski:handle-stream

Conversation

@YvanMokwinski

@YvanMokwinski YvanMokwinski commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor

Motivation

JIRA ID: ROCM-28136

Removing a leftover from an experiment to run our test suites on a non-default stream.

Technical Details

Removes the creation of a stream rather than using the default one.

Test Plan

A test is in place to make sure we won't regress.

Test Result

unit tests are passing.

@therock-pr-bot

therock-pr-bot Bot commented Sep 14, 2026 •

Copy link
Copy Markdown

✅ All Policy Checks Passed

Check Status Details
📝 PR Description ✅ Pass —
⛔ Forbidden Files ✅ Pass —
🧪 Unit Test ⚠️ Warning Error: Source/code files changed without an accompanying unit test.
Expected: add at least one test file named like test_<name>.py / test_<name>.cpp (or <name>_test.*).
Current: code file(s) changed: projects/rocsparse/clients/unittests/unit_test_host_auxiliary.cpp, projects/rocsparse/library/src/common/rocsparse_handle.cpp; no test file found
🚫 Draft PR 🔜 To Be Enabled —
🚩 Feature Flag 🔜 To Be Enabled —
📊 Code Coverage 🔜 To Be Enabled —

🎉 All policy checks passed!

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

@therock-pr-bot

Copy link
Copy Markdown

🚫 Please fix the failed policies before requesting reviews.

The following policy checks failed:

  • ❌ PR Description

The Not ready to Review label has been added to this PR.
Once all policies pass, the label will be removed automatically.

@codecov

codecov Bot commented Sep 14, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #12079      +/-   ##
===========================================
+ Coverage    70.23%   70.24%   +0.01%     
===========================================
  Files         2810     2810              
  Lines       462535   462429     -106     
  Branches     68103    68085      -18     
===========================================
- Hits        324833   324820      -13     
+ Misses      114182   114087      -95     
- Partials     23520    23522       +2     
Flag Coverage Δ *Carryforward flag
TensileLite-CPP 46.40% <ø> (ø) Carriedforward from a8b6476
TensileLite-Unit 76.08% <ø> (ø) Carriedforward from a8b6476
hipBLAS 90.62% <ø> (ø) Carriedforward from a8b6476
hipBLASLt 35.24% <ø> (ø) Carriedforward from a8b6476
hipCUB 82.68% <ø> (ø) Carriedforward from a8b6476
hipDNN 87.02% <ø> (ø) Carriedforward from a8b6476
hipFFT 43.07% <ø> (ø) Carriedforward from a8b6476
hipRAND 76.12% <ø> (ø) Carriedforward from a8b6476
hipSOLVER 68.92% <ø> (ø) Carriedforward from a8b6476
hipSPARSE 86.99% <ø> (ø) Carriedforward from a8b6476
rocBLAS 48.31% <ø> (ø) Carriedforward from a8b6476
rocFFT 47.30% <ø> (+0.13%) ⬆️ Carriedforward from a8b6476
rocRAND 56.90% <ø> (ø) Carriedforward from a8b6476
rocSOLVER 76.83% <ø> (ø) Carriedforward from a8b6476
rocSPARSE 74.61% <100.00%> (-<0.01%) ⬇️
rocThrust 91.60% <ø> (ø) Carriedforward from a8b6476

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
.../rocsparse/library/src/common/rocsparse_handle.cpp 35.20% <100.00%> (-1.27%) ⬇️

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ntrost57 ntrost57 changed the title Removing non-sense stream creation I introduced. (fix)rocsparse: Removing non-sense stream creation I introduced. Sep 15, 2026
@ntrost57 ntrost57 changed the title (fix)rocsparse: Removing non-sense stream creation I introduced. fix(rocsparse): Removing non-sense stream creation I introduced. Sep 15, 2026
@YvanMokwinski
YvanMokwinski merged commit 386a973 into ROCm:develop Sep 16, 2026
192 of 205 checks passed
@assistant-librarian

Copy link
Copy Markdown
Contributor

TheRock Submodule Bump Activity

Newest first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants